Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to manually restart an app when crashed #764

Closed
hstonge opened this issue Jan 22, 2016 · 7 comments
Closed

Should be able to manually restart an app when crashed #764

hstonge opened this issue Jan 22, 2016 · 7 comments

Comments

@hstonge
Copy link

hstonge commented Jan 22, 2016

When an app crashes and nodemon outputs [nodemon] app crashed - waiting for file changes before starting..., we should still be able to manually restart the app.

This is useful in the case the crash was caused by a piece of code found inside ignored folders, or when the crash is caused by an invalid external resource outside of nodemon's watch domain.

At the moment, typing rs + carriage return when crashed yields no effect.

@wmcmurray
Copy link

+1 ! 👍

@mpint
Copy link

mpint commented Feb 3, 2016

I'm using gulp-nodemon (runs nodemon 1.8.1) and am able to 'rs' after aggressively killing the server with kill -9 <pid>

@hstonge
Copy link
Author

hstonge commented Feb 3, 2016

I've updated nodemon to 1.8.1 to make sure, but the problem is still present on OS X 10.10.5, node 4.2.3.

To reproduce:
1- Save a new file with this content:

setTimeout(function(){
  var test = {};
  test.crashMe();
}, 0);

2- Run the file via nodemon, it will crash;
3- Try to restart by typing "rs" + Enter.

@hstonge
Copy link
Author

hstonge commented Mar 8, 2016

Bumping for news regarding this...

@jcollum-cambia
Copy link

I think you can type rs and Enter and it will restart now.

@hstonge
Copy link
Author

hstonge commented Jun 30, 2017

@jcollum-cambia Indeed it does; i kind of forgot about this report 😑

I'm closing the issue.

@adipascu
Copy link

adipascu commented Nov 17, 2018

On the latest version (1.18.6) I can no longer restart the app with rs after a crash.
Is this working as intended?
edit: its fixed in 1.18.9, see: #1490 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants