Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is rs supposed to work after the app crashed? #1490

Closed
i5o opened this issue Dec 13, 2018 · 7 comments
Closed

Is rs supposed to work after the app crashed? #1490

i5o opened this issue Dec 13, 2018 · 7 comments
Labels
bug confirmed bug has PR

Comments

@i5o
Copy link

i5o commented Dec 13, 2018

  • nodemon -v: 1.18.7
  • node -v: v11.3.0
  • Operating system/terminal environment: MacOS Mojave 10.14.2 / iterm2
  • Command you ran: nodemon index.js

Question

Hello. Is nodemon supposed to restart if I write rs after a script fails?
If that is the case, this isn't working on my system.
If that isn't, that would be a cool feature request.
image

@remy
Copy link
Owner

remy commented Dec 13, 2018

Yes it should.

Please can you provide full details on how to replicate (with a fully parred down example case).

@remy remy added the missing code to replicate Can't replicate the issue until there is sample code label Dec 13, 2018
@i5o
Copy link
Author

i5o commented Dec 13, 2018

@remy thanks for replying.
The code I had is basically a express server, and that's it.
When it fails "rs" doesn't get detected.

This is the example code that will just reproduce the error:

const express = require('express');
var app = express();
app.listen('7003', '0.0.0.0', function() {
  throw 'hey'
});

Save it to index.js and then nodemon index.js
image

@remy
Copy link
Owner

remy commented Dec 13, 2018

Can you give it a try with the latest nodemon? 1.18.8

@i5o
Copy link
Author

i5o commented Dec 13, 2018

Not working

image

@remy remy removed the missing code to replicate Can't replicate the issue until there is sample code label Dec 14, 2018
@remy
Copy link
Owner

remy commented Dec 14, 2018

I'm able to replicate.

It's specific to node@11.x - as it's not a problem in node@10.

If you want to have a go at a PR, I'd be happy to merge (not sure this area of code has tests though…).

@remy remy added the bug confirmed bug label Dec 14, 2018
remy added a commit that referenced this issue Dec 14, 2018
@remy remy added the has PR label Dec 14, 2018
@remy
Copy link
Owner

remy commented Dec 14, 2018

Fixed in nodemon@1.18.9

@remy remy closed this as completed Dec 14, 2018
@i5o
Copy link
Author

i5o commented Dec 14, 2018

Can confirm it's fixed on 1.18.9 :)

image

Thanks. 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bug has PR
Projects
None yet
Development

No branches or pull requests

2 participants