-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on check #1
Comments
Interesting. The code spots that you're using microformats, so tries to extract the microformat I could attempt a non-microformat parse, but I wonder if that's the right thing to do. Do you have any thoughts on what's right here? |
A common pattern for reply posts is displaying the reply context with an I realized my example is a bit odd and I should probably tweak my microformats. I should use These are the two main patterns that you might consider handling for replies: u-in-reply-to <div class="h-entry">
In reply to <a href="https://example.com/post" class="u-in-reply-to">https://example.com/post</a>:
<div class="e-content">Lorem ipsum</div>
</div> Parsed as (truncated to just the "items": [
{
"type": [
"h-entry"
],
"properties": {
"in-reply-to": [
"https://example.com/post"
],
"content": [
{
"html": "Lorem ipsum",
"value": "Lorem ipsum"
}
]
}
}
] u-in-reply-to h-cite <div class="h-entry">
<div class="u-in-reply-to h-cite">
<a href="https://example.com/author" class="p-author h-card">John Doe</a>
<a href="https://example.com/post" class="u-url">https://example.com/post</a>
<span class="p-content">Quoted post</span>
</div>
<div class="e-content">Lorem ipsum</div>
</div> Parsed as (truncated to just the "items": [
{
"type": [
"h-entry"
],
"properties": {
"content": [
{
"html": "Lorem ipsum",
"value": "Lorem ipsum"
}
],
"in-reply-to": [
{
"type": [
"h-cite"
],
"properties": {
"content": [
"Quoted post"
],
"url": [
"https://example.com/post"
],
"author": [
{
"type": [
"h-card"
],
"properties": {
"name": [
"John Doe"
],
"url": [
"https://example.com/author"
]
},
"value": "John Doe"
}
]
},
"value": "https://example.com/post"
}
]
}
}
] The logic could be: for each in-reply-to, if it is an object, use its value as a URL; otherwise use the string as a URL. Note that it's possible to have multi-reply posts, too. |
Okay, I think I can see what I need to do to handle this. I might park off multi-reply for another day / when folks need/want it! I'm going to pick this up tomorrow and bake another release and pingback here once ready 👍 |
This should be fixed and live! Thanks for waiting! |
URL: https://gregorlove.com/2019/06/jealous/
Status: 200
Error:
No webmentions found on 1 discovered entries
Tantek's URL advertises webmention endpoint:
<link rel="webmention" href="//webmention.io/tantek.com/webmention" />
The text was updated successfully, but these errors were encountered: