upsert does not modify author upon update. fixes #256

remyla · Jan 7, 2021 · f8b9fe0 · f8b9fe0
1 parent e42a426
commit f8b9fe0
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/server-nodejs/routes/cruds.js b/server-nodejs/routes/cruds.js
@@ -204,24 +204,26 @@ module.exports = function (app, routes) {
      */
     upsert = function (req, res) {
         var nodes = Array.isArray(req.body) ? req.body : [req.body];
-        var controlProperties = {
-            author: req.user.username,
-            time: Date.now()
-        }
         for (var i = 0; i < nodes.length; ++i) {
             if ('object' !== typeof nodes[i] || null === nodes[i]) {
                 return httpStatus(res, 400, 'Upsert');
             }
-            nodes[i] = Object.assign({}, controlProperties, nodes[i]);
         }
         nodes = unfoldIds(nodes);
         for(var i in nodes) {
             if(nodes[i]._id === 'null') {
                 delete nodes[i]._id;
             }
         }
-
-        db.create(nodes, function(err, result) {
+        var array = [];
+        var controlProperties = {
+            author: req.user.username,
+            time: Date.now()
+        }
+        for (var i = 0; i < nodes.length; ++i) {
+            array.push(Object.assign({}, controlProperties, nodes[i]));
+        }
+        db.create(array, function(err, result) {
             if(err) {
                 return httpStatus(res, 500, 'Upsert');
             }
@@ -232,7 +234,7 @@ module.exports = function (app, routes) {
                     toUpdate.push(nodes[i]);
                 }
                 else {
-                    created.push(nodes[i]);
+                    created.push(array[i]);
                 }
             }
             var response = getMultipleResponse(result);