Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add goreleaser #41

Merged
merged 2 commits into from
Mar 30, 2021
Merged

feat: Add goreleaser #41

merged 2 commits into from
Mar 30, 2021

Conversation

bradbeam
Copy link
Contributor

@bradbeam bradbeam commented Mar 1, 2021

This introduces goreleaser as the means by which we will release vhs.
This should include packaging vhs as a debian as well as producing
a container image.

There's still quite a bit of cleanup and whatnot that needs to happen, but this should set the direction.

Signed-off-by: Brad Beam brad.beam@stormforge.io

@qedrakmar
Copy link
Member

As this is bringing in an outside package, it is worth commenting on that package.

GoReleaser uses MIT license, which while not called out in our contributor's guide, is close enough in alignment to the ApacheV2 we use to be acceptable. From a governance and licensing standpoint, LGTM.

@bradbeam bradbeam force-pushed the packages branch 3 times, most recently from 96e8fbf to 072fd37 Compare March 9, 2021 19:09
This introduces goreleaser as the means by which we will release vhs.
This should include packaging vhs as a debian as well as producing
a container image.

Signed-off-by: Brad Beam <brad.beam@stormforge.io>
@bradbeam
Copy link
Contributor Author

I think this is mostly there, wouldn't mind getting it merged to play around with cutting some prereleases and see how the process goes.

@bradbeam bradbeam marked this pull request as ready for review March 17, 2021 16:10
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/pr.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ztreinhart ztreinhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR merges the Dockerfiles in the repo / deprecates the original vhs-dev container, does it make sense to remove the make dev entry from the Makefile? As a broader question, does it still make sense to have a standardized development container, or no? Other than that, looks good to me! 👍

Co-authored-by: Stephan <zeisss@moinz.de>
@ztreinhart ztreinhart merged commit 9f990c1 into rename-this:main Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants