-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors config to separate general config from flow config #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! A couple changes but looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, but I need one more change and it's my bad for not noticing this on the first round.
These config settings also need to be on FlowConfig
:
Lines 7 to 11 in ef2581e
Addr string | |
CaptureResponse bool | |
Middleware string | |
TCPTimeout time.Duration | |
HTTPTimeout time.Duration |
Lines 15 to 18 in ef2581e
GCSBucketName string | |
GCSObjectName string | |
BufferOutput bool |
These config settings get used by the flow and can change from run to run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR gets the ball rolling for eventually implementing
vhsd
. When runningvhs
, it's essentially a single run, but withvhsd
we can expect it to run indefinitely while running many flows. Starting upvhsd
should not require any flow specific configuration, but will probably share a lot of config settings with avhs
run.