Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for persistent Pixi shells #5

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

renan-r-santos
Copy link
Owner

@renan-r-santos renan-r-santos commented Apr 6, 2024

prefix-dev/pixi#1080 introduced a feature that allows for a persistent manifest-path when operating within a Pixi shell.
This PR supports this by always passing --manifest-path when invoking pixi.
@abkfenris in case you want to take a look.

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 63.26%. Comparing base (f0a85f0) to head (8550131).
Report is 1 commits behind head on main.

Files Patch % Lines
src/pixi_kernel/__main__.py 52.94% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   62.88%   63.26%   +0.37%     
==========================================
  Files           4        4              
  Lines          97       98       +1     
  Branches       14       15       +1     
==========================================
+ Hits           61       62       +1     
  Misses         32       32              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@abkfenris abkfenris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks like it does the trick in a quick test of the environment I'm trying to move from miniconda/nb-conda-kernels.

@renan-r-santos renan-r-santos merged commit 5af855d into main Apr 7, 2024
20 checks passed
@renan-r-santos renan-r-santos deleted the manifest-path branch April 7, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants