Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BootstrapFormHelper::error() method signature incompatible with FormHelper::error() #3

Merged
merged 1 commit into from
May 30, 2012

Conversation

TiuTalk
Copy link
Contributor

@TiuTalk TiuTalk commented May 26, 2012

Declaration of BootstrapFormHelper::error() should be compatible with FormHelper::error($field, $text = NULL, $options = Array)

@kvz
Copy link
Contributor

kvz commented May 30, 2012

lgtm. thanks!
for reference, here's the original signature https://github.com/cakephp/cakephp/blob/2.1/lib/Cake/View/Helper/FormHelper.php#L657

kvz added a commit that referenced this pull request May 30, 2012
BootstrapFormHelper::error() method signature incompatible with FormHelper::error()
@kvz kvz merged commit 578d301 into renan:master May 30, 2012
@ghost ghost assigned kvz May 30, 2012
@TiuTalk TiuTalk unassigned kvz Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants