Adding executable guard to Dockerfile

[motleydev]

At least "this" user forgot to make the script executable while moving files about. For those who work with bash scripts less frequently. Again, like this user, this is a good tip picked up from https://nickjanetakis.com/blog/docker-tip-86-always-make-your-entrypoint-scripts-executable to help guard against this case.

[anuaimi]

Glad it's working.

One note, while the current fix works, the more common way to resolve this it to change the permission on the file itself rather than when you run it in Docker.

chmod +x entrypoint.sh
git add entrypoint.sh
git commit -m "fix permissions on entrypoint script"

Now the file can be run as a script no matter if you run it locally or in a docker container.

This is just a FYI as both approaches will work in your current scenario.

[crcastle]

Hi @motleydev- It looks like that file is set as executable (like @anuaimi suggests) so RUN chmod +x /opt/render/entrypoint.sh shouldn't be required in the Dockerfile:

Did you maybe edit it or recreate it?

[motleydev]

@crcastle Yes, if you take the default example, but if you move files around, or copy and paste from the web, the problem occurs when some file action (new, copy, etc) results in a non executable - which after some Googling, appears to happen fairly often which is why that line was listed as a good practice or "tip", feel free to reject this PR if you don't find it helpful, I just thought it's a simple step that mitigates this exact scenario, but I'm a sample point of one :)

[crcastle]

@motleydev I believe your change cannot do any harm because chmod is idempotent. Thanks for the PR!