Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding "inclusive" option to takeWhile #21

Merged
merged 2 commits into from
Oct 3, 2023
Merged

adding "inclusive" option to takeWhile #21

merged 2 commits into from
Oct 3, 2023

Conversation

tsouza
Copy link
Contributor

@tsouza tsouza commented Oct 3, 2023

takeWhile operator should accept an inclusive option:

When set to true the value that caused predicate to return false will also be emitted.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
lib/src/operators/take_while.dart 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@renggli renggli merged commit 14591f5 into renggli:main Oct 3, 2023
3 checks passed
@tsouza tsouza deleted the takeWhile-inclusive branch October 3, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsouza @renggli @tsouza-squid