fix(datasource/helm): Digests are blank on Gitlab (#24280)

renovatebot · Sep 7, 2023 · 4b616c2 · 4b616c2
1 parent 53b7b6f
commit 4b616c2
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 3 deletions.
diff --git a/lib/modules/datasource/helm/__fixtures__/index_blank-digest.yaml b/lib/modules/datasource/helm/__fixtures__/index_blank-digest.yaml
@@ -0,0 +1,14 @@
+apiVersion: v1
+entries:
+  blank-digest:
+  - apiVersion: v2
+    created: '2023-09-05T13:24:19.046604000Z'
+    description: A Helm chart with a blank digest
+    digest:
+    name: blank-digest
+    urls:
+    - charts/blank-digest-3.2.1.tgz
+    version: 3.2.1
+generated: '2023-09-06T15:21:28.525139938Z'
+serverInfo:
+  contextPath: "/api/v4/projects/98765431/packages/helm"
diff --git a/lib/modules/datasource/helm/index.spec.ts b/lib/modules/datasource/helm/index.spec.ts
@@ -56,7 +56,7 @@ describe('modules/datasource/helm/index', () => {
       httpMock
         .scope('https://example-repository.com')
         .get('/index.yaml')
-        .reply(200, undefined);
+        .reply(200);
       expect(
         await getPkgReleases({
           datasource: HelmDatasource.id,
@@ -203,5 +203,27 @@ describe('modules/datasource/helm/index', () => {
         releases: expect.toBeArrayOfSize(27),
       });
     });
+
+    it('uses undefined as the newDigest when no digest is provided', async () => {
+      httpMock
+        .scope('https://example-repository.com')
+        .get('/index.yaml')
+        .reply(200, Fixtures.get('index_blank-digest.yaml'));
+      const releases = await getPkgReleases({
+        datasource: HelmDatasource.id,
+        packageName: 'blank-digest',
+        registryUrls: ['https://example-repository.com'],
+      });
+      expect(releases).toMatchObject({
+        registryUrl: 'https://example-repository.com',
+        releases: [
+          {
+            newDigest: undefined,
+            releaseTimestamp: '2023-09-05T13:24:19.046Z',
+            version: '3.2.1',
+          },
+        ],
+      });
+    });
   });
 });
diff --git a/lib/modules/datasource/helm/index.ts b/lib/modules/datasource/helm/index.ts
@@ -71,7 +71,8 @@ export class HelmDatasource extends Datasource {
           releases: releases.map((release) => ({
             version: release.version,
             releaseTimestamp: release.created ?? null,
-            newDigest: release.digest,
+            // The Helm repository at Gitlab does not include a digest (#24280)
+            newDigest: release.digest ?? undefined,
           })),
         };
       }

diff --git a/lib/modules/datasource/helm/types.ts b/lib/modules/datasource/helm/types.ts
@@ -5,7 +5,7 @@ export interface HelmRelease {
   sources?: string[];
   version: string;
   created: string;
-  digest: string;
+  digest: string | null;
   urls: string[];
 }