-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datasource/helm): Digests are blank on Gitlab #24280
Merged
viceice
merged 5 commits into
renovatebot:main
from
mpkorstanje:fix/datasource-helm-without-digest
Sep 7, 2023
Merged
fix(datasource/helm): Digests are blank on Gitlab #24280
viceice
merged 5 commits into
renovatebot:main
from
mpkorstanje:fix/datasource-helm-without-digest
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In renovatebot#23432 support was added for digests. This introduces a regression when used in combination with the Helm repository on Gitlab. In the `index.yaml` generated by Gitlabs Helm Repository the digest is left blank. For example: ``` apiVersion: v2 entries: blank-digest: - apiVersion: v2 created: '2023-09-05T13:25:19.046604000Z' description: A Helm chart with a blank digest digest: name: blank-digest urls: - https://charts.helm.sh/stable/packages/ambassador-2.7.0.tgz version: 2.7.0 ``` As a result `newDigest: release.digest` will set the `newDigest` to `null` and this causes the update to be removed in `workers/repository/process/lookup/index.ts`.
viceice
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
viceice
previously approved these changes
Sep 7, 2023
auto-merge was automatically disabled
September 7, 2023 17:13
Head branch was pushed to by a user without write access
viceice
approved these changes
Sep 7, 2023
🎉 This PR is included in version 36.87.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensures that
newDigest
is not set tonull
when it is left blank in theindex.yaml
.Context
In #23432 support was added for digests. This introduces a regression when used in combination with the Helm repository on Gitlab. As a result packages hosted in the Gitlab Helm repository are no longer updated.
In the
index.yaml
generated by Gitlabs Helm Repository the digest is left blank. For example:As a result
newDigest: release.digest
will set thenewDigest
tonull
renovate/lib/modules/datasource/helm/index.ts
Lines 68 to 75 in 2431c5a
and this causes the update to be removed in
workers/repository/process/lookup/index.ts
.renovate/lib/workers/repository/process/lookup/index.ts
Lines 464 to 469 in 2431c5a
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: