Skip to content

Commit

Permalink
feat(maven-wrapper): Add manager to update maven wrapper version (#15660
Browse files Browse the repository at this point in the history 
)
  • Loading branch information
@benkelaar
benkelaar committed Jan 23, 2023
1 parent 8e8cbba commit 744488f
Show file tree
Hide file tree
Showing 8 changed files with 697 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/modules/manager/api.ts
View file
Expand Up @@ -47,6 +47,7 @@ import * as kubernetes from './kubernetes';
import * as kustomize from './kustomize';
import * as leiningen from './leiningen';
import * as maven from './maven';
import * as mavenWrapper from './maven-wrapper';
import * as meteor from './meteor';
import * as mint from './mint';
import * as mix from './mix';
Expand Down Expand Up @@ -133,6 +134,7 @@ api.set('kubernetes', kubernetes);
api.set('kustomize', kustomize);
api.set('leiningen', leiningen);
api.set('maven', maven);
api.set('maven-wrapper', mavenWrapper);
api.set('meteor', meteor);
api.set('mint', mint);
api.set('mix', mix);
Expand Down
311 changes: 311 additions & 0 deletions lib/modules/manager/maven-wrapper/artifacts.spec.ts
View file
@@ -0,0 +1,311 @@
import type { Stats } from 'fs';
import os from 'os';
import type { StatusResult } from 'simple-git';
import { join } from 'upath';
import { envMock, mockExecAll } from '../../../../test/exec-util';
import { env, fs, git, mockedFunction, partial } from '../../../../test/util';
import { GlobalConfig } from '../../../config/global';
import { resetPrefetchedImages } from '../../../util/exec/docker';
import { getPkgReleases } from '../../datasource';
import { updateArtifacts } from '.';

jest.mock('../../../util/fs');
jest.mock('../../../util/git');
jest.spyOn(os, 'platform').mockImplementation(() => 'darwin');
jest.mock('../../../util/exec/env');
jest.mock('../../datasource');
process.env.CONTAINERBASE = 'true';

function mockMavenFileChangedInGit(fileName = 'maven-wrapper.properties') {
git.getRepoStatus.mockResolvedValueOnce(
partial<StatusResult>({
modified: [`maven.mvn/wrapper/${fileName}`],
})
);
}

describe('modules/manager/maven-wrapper/artifacts', () => {
beforeEach(() => {
GlobalConfig.set({ localDir: join('/tmp/github/some/repo') });
jest.resetAllMocks();
fs.statLocalFile.mockResolvedValue(
partial<Stats>({
isFile: () => true,
mode: 0o555,
})
);

resetPrefetchedImages();

env.getChildProcessEnv.mockReturnValue({
...envMock.basic,
LANG: 'en_US.UTF-8',
LC_ALL: 'en_US',
});
mockedFunction(getPkgReleases).mockResolvedValueOnce({
releases: [
{ version: '8.0.1' },
{ version: '11.0.1' },
{ version: '16.0.1' },
{ version: '17.0.0' },
],
});
});

afterEach(() => {
GlobalConfig.reset();
});

it('Should not update if there is no dep with maven:wrapper', async () => {
const execSnapshots = mockExecAll({ stdout: '', stderr: '' });
const updatedDeps = await updateArtifacts({
packageFileName: 'maven-wrapper',
newPackageFileContent: '',
updatedDeps: [{ depName: 'not-mavenwrapper' }],
config: {},
});
expect(updatedDeps).toBeNull();
expect(execSnapshots).toBeEmptyArray();
});

it('Docker should use java 8 if version is lower then 2.0.0', async () => {
mockMavenFileChangedInGit();
const execSnapshots = mockExecAll();
GlobalConfig.set({ localDir: './', binarySource: 'docker' });
const updatedDeps = await updateArtifacts({
packageFileName: 'maven',
newPackageFileContent: '',
updatedDeps: [{ depName: 'maven-wrapper' }],
config: {
currentValue: '2.0.0',
newValue: '3.3.1',
constraints: undefined,
},
});

const expected = [
{
file: {
contents: undefined,
path: 'maven.mvn/wrapper/maven-wrapper.properties',
type: 'addition',
},
},
];

expect(execSnapshots[2].cmd).toContain('java 8.0.1');
expect(updatedDeps).toEqual(expected);
});

it('Should update when it is maven wrapper', async () => {
mockMavenFileChangedInGit();
const execSnapshots = mockExecAll({ stdout: '', stderr: '' });
const updatedDeps = await updateArtifacts({
packageFileName: 'maven',
newPackageFileContent: '',
updatedDeps: [{ depName: 'maven-wrapper' }],
config: { currentValue: '3.3.1', newValue: '3.3.1' },
});

const expected = [
{
file: {
contents: undefined,
path: 'maven.mvn/wrapper/maven-wrapper.properties',
type: 'addition',
},
},
];
expect(updatedDeps).toEqual(expected);
expect(execSnapshots).toEqual([
{
cmd: './mvnw wrapper:wrapper',
options: {
cwd: '/tmp/github',
encoding: 'utf-8',
env: {
HOME: '/home/user',
HTTPS_PROXY: 'https://example.com',
HTTP_PROXY: 'http://example.com',
LANG: 'en_US.UTF-8',
LC_ALL: 'en_US',
NO_PROXY: 'localhost',
PATH: '/tmp/path',
},
maxBuffer: 10485760,
timeout: 900000,
},
},
]);
});

it('Should not update deps when maven-wrapper.properties is not in git change', async () => {
mockMavenFileChangedInGit('not-maven-wrapper.properties');
const execSnapshots = mockExecAll({ stdout: '', stderr: '' });
const updatedDeps = await updateArtifacts({
packageFileName: 'maven',
newPackageFileContent: '',
updatedDeps: [{ depName: 'maven-wrapper' }],
config: { newValue: '3.3.1' },
});
expect(updatedDeps).toEqual([]);
expect(execSnapshots).toEqual([
{
cmd: './mvnw wrapper:wrapper',
options: {
cwd: '/tmp/github',
encoding: 'utf-8',
env: {
HOME: '/home/user',
HTTPS_PROXY: 'https://example.com',
HTTP_PROXY: 'http://example.com',
LANG: 'en_US.UTF-8',
LC_ALL: 'en_US',
NO_PROXY: 'localhost',
PATH: '/tmp/path',
},
maxBuffer: 10485760,
timeout: 900000,
},
},
]);
});

it('updates with docker', async () => {
mockMavenFileChangedInGit();
GlobalConfig.set({ localDir: './', binarySource: 'docker' });
const execSnapshots = mockExecAll({ stdout: '', stderr: '' });
const result = await updateArtifacts({
packageFileName: 'maven',
newPackageFileContent: '',
updatedDeps: [{ depName: 'maven-wrapper' }],
config: { currentValue: '3.3.0', newValue: '3.3.1' },
});
expect(result).toEqual([
{
file: {
contents: undefined,
path: 'maven.mvn/wrapper/maven-wrapper.properties',
type: 'addition',
},
},
]);
expect(execSnapshots).toMatchObject([
{
cmd: 'docker pull renovate/sidecar',
options: { encoding: 'utf-8' },
},
{ cmd: 'docker ps --filter name=renovate_sidecar -aq' },
{
cmd:
'docker run --rm --name=renovate_sidecar --label=renovate_child ' +
'-v "./":"./" ' +
'-e BUILDPACK_CACHE_DIR ' +
'-e CONTAINERBASE_CACHE_DIR ' +
'-w "../.." ' +
'renovate/sidecar' +
' bash -l -c "' +
'install-tool java 17.0.0 ' +
'&& ' +
'./mvnw wrapper:wrapper"',
options: {
cwd: '../..',
encoding: 'utf-8',
env: {
HOME: '/home/user',
HTTPS_PROXY: 'https://example.com',
HTTP_PROXY: 'http://example.com',
LANG: 'en_US.UTF-8',
LC_ALL: 'en_US',
NO_PROXY: 'localhost',
PATH: '/tmp/path',
},
maxBuffer: 10485760,
timeout: 900000,
},
},
]);
});

it('Should return null when cmd is not found', async () => {
mockMavenFileChangedInGit('also-not-maven-wrapper.properties');
jest.spyOn(os, 'platform').mockImplementation(() => 'win32');
const execSnapshots = mockExecAll({ stdout: '', stderr: '' });
fs.statLocalFile.mockResolvedValue(null);
const updatedDeps = await updateArtifacts({
packageFileName: 'maven',
newPackageFileContent: '',
updatedDeps: [{ depName: 'maven-wrapper' }],
config: { newValue: '3.3.1' },
});
expect(updatedDeps).toBeNull();
expect(execSnapshots).toMatchObject([]);
});

it('Should throw an error when it cant execute', async () => {
mockMavenFileChangedInGit();
mockExecAll(new Error('temporary-error'));
const updatedDeps = await updateArtifacts({
packageFileName: 'maven',
newPackageFileContent: '',
updatedDeps: [{ depName: 'maven-wrapper' }],
config: { currentValue: '3.0.0', newValue: '3.3.1' },
});

expect(updatedDeps).toEqual([
{
artifactError: {
lockFile: 'maven',
stderr: 'temporary-error',
},
},
]);
});

it('updates with binarySource install', async () => {
const execSnapshots = mockExecAll({ stdout: '', stderr: '' });
mockMavenFileChangedInGit();
GlobalConfig.set({
localDir: join('/tmp/github/some/repo'),
binarySource: 'install',
});
const updatedDeps = await updateArtifacts({
packageFileName: 'maven',
newPackageFileContent: '',
updatedDeps: [{ depName: 'maven-wrapper' }],
config: { currentValue: '3.0.0', newValue: '3.3.1' },
});

expect(execSnapshots).toMatchObject([
{ cmd: 'install-tool java 17.0.0' },
{
cmd: './mvnw wrapper:wrapper',
options: {
cwd: '/tmp/github',
encoding: 'utf-8',
env: {
HOME: '/home/user',
HTTPS_PROXY: 'https://example.com',
HTTP_PROXY: 'http://example.com',
LANG: 'en_US.UTF-8',
LC_ALL: 'en_US',
NO_PROXY: 'localhost',
PATH: '/tmp/path',
},
maxBuffer: 10485760,
timeout: 900000,
},
},
]);

expect(updatedDeps).toEqual([
{
file: {
contents: undefined,
path: 'maven.mvn/wrapper/maven-wrapper.properties',
type: 'addition',
},
},
]);
});
});

0 comments on commit 744488f

Please sign in to comment.