refactor(datasource/crate): Enable strict null checks (#13915)

lib/datasource/crate/index.spec.ts

@@ -341,6 +341,8 @@ describe('datasource/crate/index', () => {
   describe('fetchCrateRecordsPayload', () => {
     it('rejects if it has neither clonePath nor crates.io flavor', async () => {
       const info: RegistryInfo = {
+        rawUrl: 'https://example.com',
+        url: new URL('https://example.com'),
         flavor: RegistryFlavor.Cloudsmith,
       };
       const crateDatasource = new CrateDatasource();

lib/datasource/crate/index.ts

@@ -8,6 +8,7 @@ import { cache } from '../../util/cache/package/decorator';
 import { privateCacheDir, readFile } from '../../util/fs';
 import { simpleGitConfig } from '../../util/git/config';
 import { newlineRegex, regEx } from '../../util/regex';
+import { parseUrl } from '../../util/url';
 import * as cargoVersioning from '../../versioning/cargo';
 import { Datasource } from '../datasource';
 import type { GetReleasesConfig, Release, ReleaseResult } from '../types';
@@ -163,10 +164,13 @@ export class CrateDatasource extends Datasource {
     lookupName,
     registryUrl,
   }: GetReleasesConfig): Promise<RegistryInfo | null> {
-    let url: URL;
-    try {
-      url = new URL(registryUrl);
-    } catch (err) {
+    // istanbul ignore if
+    if (!registryUrl) {
+      return null;
+    }
+
+    const url = parseUrl(registryUrl);
+    if (!url) {
       logger.debug({ registryUrl }, 'could not parse registry URL');
       return null;
     }
@@ -256,7 +260,9 @@ export class CrateDatasource extends Datasource {
     return registry;
   }
 
-  private static areReleasesCacheable(registryUrl: string): boolean {
+  private static areReleasesCacheable(
+    registryUrl: string | undefined
+  ): boolean {
     // We only cache public releases, we don't want to cache private
     // cloned data between runs.
     return registryUrl === 'https://crates.io';

lib/datasource/crate/types.ts

@@ -14,10 +14,10 @@ export interface RegistryInfo {
   flavor: RegistryFlavor;
 
   /** raw URL of the registry, as specified in cargo config */
-  rawUrl?: string;
+  rawUrl: string;
 
   /** parsed URL of the registry */
-  url?: URL;
+  url: URL;
 
   /** path where the registry is cloned */
   clonePath?: string;

lib/util/url.spec.ts

@@ -72,8 +72,8 @@ describe('util/url', () => {
   });
 
   it('parses URL', () => {
-    expect(parseUrl(null as never)).toBeNull();
-    expect(parseUrl(undefined as never)).toBeNull();
+    expect(parseUrl(null)).toBeNull();
+    expect(parseUrl(undefined)).toBeNull();
 
     const url = parseUrl('https://github.com/renovatebot/renovate');
     expect(url?.protocol).toBe('https:');

lib/util/url.ts

@@ -67,7 +67,11 @@ export function validateUrl(url?: string, httpOnly = true): boolean {
   }
 }
 
-export function parseUrl(url: string): URL | null {
+export function parseUrl(url: string | undefined | null): URL | null {
+  if (!url) {
+    return null;
+  }
+
   try {
     return new URL(url);
   } catch (err) {

tsconfig.strict.json

@@ -81,7 +81,6 @@
     "lib/datasource/artifactory/index.ts",
     "lib/datasource/bitbucket-tags/index.ts",
     "lib/datasource/cdnjs/index.ts",
-    "lib/datasource/crate/index.ts",
     "lib/datasource/datasource.ts",
     "lib/datasource/docker/common.ts",
     "lib/datasource/docker/index.ts",