fix(datasource/helm): Skip helm charts with no listed versions #23223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been seen with the helm chart index at https://download.onlyoffice.com/charts/stable , which causes processing for charts with releases to be skipped as well.
viceice
requested changes
Jul 7, 2023
- Changed snapshot to matchobject - Simplified test data - Reduced scope of variables
|
Comments all addressed. Please let me know if any other changes are required/if this branch needs to be rebased on main. |
viceice
reviewed
Jul 17, 2023
lib/modules/datasource/helm/__fixtures__/index_emptypackage.yaml
Outdated
Show resolved
Hide resolved
viceice
approved these changes
Jul 17, 2023
|
🎉 This PR is included in version 36.9.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When parsing the helm chart index, ignore any charts with no listed releases.
Context
This has been seen with the helm chart index at
https://download.onlyoffice.com/charts/stable/index.yaml , which causes processing for charts with releases to be skipped as well. The normal helm chart to deploy is
docs, but there is another chartdocumentserverthat has no releases and causes renovate to be unable to monitor thedocschart.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: