Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): support setting file mode #12081

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Conversation

ylemkimon
Copy link
Contributor

Changes:

Support setting the file mode (chmod) in git.commitFiles()

Context:

Sometimes, there is a need to set the file mode in committed files, e.g., executables.

This is a blocking issue for #11368.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit 807f124 into renovatebot:main Oct 9, 2021
@ylemkimon
Copy link
Contributor Author

ylemkimon commented Oct 9, 2021

@rarkins does the Windows test only run on pushes not on PRs? fs.mode would probably not be portable on Windows and I didn't know Renovate supports Windows, sorry.

@rarkins
Copy link
Collaborator

rarkins commented Oct 9, 2021

Ok, let's revert and make sure to test using Windows CI for this feature specifically

@rarkins
Copy link
Collaborator

rarkins commented Oct 9, 2021

@ylemkimon Could you restore this branch and create a new PR? Then we can add multi platform tests until we've verified it works

@viceice maybe we could reserve a certain branch pattern or other technique to trigger cross platform tests without us needing to manually edit workflows per-PR?

@viceice
Copy link
Member

viceice commented Oct 9, 2021

I think we can use a manual dispatch trigger for this.

I think this can be easily handled, with multiple workflows and composite actions to reduce duplicate code.

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.31.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ylemkimon
Copy link
Contributor Author

One way I use to trigger the workflow on PRs is to use a label and labeled event.

@viceice
Copy link
Member

viceice commented Oct 9, 2021

Sounds good, can you make a small sample?

https://github.community/t/manually-triggering-checks-for-a-pr/134054

@rarkins
Copy link
Collaborator

rarkins commented Oct 9, 2021

Do we need to use the new "composable" actions to achieve DRY?

@viceice
Copy link
Member

viceice commented Oct 9, 2021

No, but it makes it easier, because of less duplicate workflow code. 😉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants