-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(git): support setting file mode #12081
Conversation
@rarkins does the Windows test only run on pushes not on PRs? |
Ok, let's revert and make sure to test using Windows CI for this feature specifically |
@ylemkimon Could you restore this branch and create a new PR? Then we can add multi platform tests until we've verified it works @viceice maybe we could reserve a certain branch pattern or other technique to trigger cross platform tests without us needing to manually edit workflows per-PR? |
I think we can use a manual dispatch trigger for this. I think this can be easily handled, with multiple workflows and composite actions to reduce duplicate code. |
🎉 This PR is included in version 27.31.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
One way I use to trigger the workflow on PRs is to use a label and |
Sounds good, can you make a small sample? https://github.community/t/manually-triggering-checks-for-a-pr/134054 |
Do we need to use the new "composable" actions to achieve DRY? |
No, but it makes it easier, because of less duplicate workflow code. 😉 |
Changes:
Support setting the file mode (
chmod
) ingit.commitFiles()
Context:
Sometimes, there is a need to set the file mode in committed files, e.g., executables.
This is a blocking issue for #11368.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: