-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/terraform): support OCI charts in helm_release #19869
feat(manager/terraform): support OCI charts in helm_release #19869
Conversation
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…orm-helm-release-oci-registry
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
…e.ts Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
…e.ts Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
OCI charts are also valid paths, therefore we need to check first if it is an OCI chart.
Sorry for the review re-request confusion, seems like I can only request one of you again. If I request both of you, it seems to remove all the requests. |
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
I went with the layout of the existing tests to not add further complication to the PR review.
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
@viceice I had the same behaviour as @morremeyer, this seems to enabled for everyone without write permissions/maintainers. |
…e.ts Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…e.ts Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…e.ts Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…orm-helm-release-oci-registry
@viceice I resolved this open question in it, since I think your prior review already approved that idea. |
🎉 This PR is included in version 34.106.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This is a follow-up to renovatebot#19869. OCI repos can be specified as part of the chart or repository, so extend OCI registry detection to the repository field too.
Changes
This adds support for helm charts published in OCI-based registries within
helm_release
resources for the terraform manager.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: