Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/terraform): support OCI registry in helm_release repository #20237

Merged
merged 5 commits into from
Feb 7, 2023

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Feb 6, 2023

Changes

Update helm_release OCI repo support to handle the repository parameter and not just the chart parameter.

Context

This is a follow-up to #19869. OCI repos can be specified as part of the chart or repository, so extend OCI registry detection to the repository field too.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

This is a follow-up to renovatebot#19869. OCI repos can be specified as part of the
chart or repository, so extend OCI registry detection to the repository
field too.
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@secustor secustor changed the title feat(manager/terraform): support OCI repos in helm_release feat(manager/terraform): support OCI registry in helm_release repository Feb 7, 2023
@secustor secustor enabled auto-merge (squash) February 7, 2023 13:05
@secustor secustor merged commit c127ead into renovatebot:main Feb 7, 2023
@jalaziz jalaziz deleted the improve-tf-oci-support branch February 7, 2023 20:46
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.128.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
@viceice viceice added the regression Issue about a regression bug, or the PR caused it label May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression Issue about a regression bug, or the PR caused it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants