Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versioning/cargo): Disable support for rangeStrategy: widen #20357

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Feb 12, 2023

Changes

This PR removes widen from the supportedRangeStrategies for the cargo versioning scheme.

Context

The || operator is not supported by cargo, so we can't possibly support widen, since it relies on || being supported.

see dtolnay/semver#57 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The `||` operator is not supported by cargo, so we can't possibly support `widen`, since it relies on `||` being supported.

see dtolnay/semver#57 (comment)
@viceice viceice changed the title fix(cargo): Disable support for rangeStrategy: widen fix(versioning/cargo): Disable support for rangeStrategy: widen Feb 12, 2023
@viceice viceice requested a review from rarkins February 12, 2023 17:29
@rarkins rarkins merged commit 36d5b07 into renovatebot:main Feb 12, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.132.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants