Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(packagist): Refactor RegistryMeta to inferred via schema #20592

Merged
merged 4 commits into from
Feb 24, 2023
Merged

refactor(packagist): Refactor RegistryMeta to inferred via schema #20592

merged 4 commits into from
Feb 24, 2023

Conversation

zharinov
Copy link
Collaborator

Changes

Move one more piece of data transformation to the schema.ts

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

viceice
viceice approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how confident that this doesn't break again?

@zharinov
Copy link
Collaborator Author

Much more confident this time, but it's better to observe the first hour or two after deploy

@zharinov zharinov mentioned this pull request Feb 23, 2023
Merged
6 tasks
@rarkins rarkins added this pull request to the merge queue Feb 24, 2023
Merged via the queue into renovatebot:main with commit fd200d4 Feb 24, 2023
@rarkins rarkins deleted the refactor/packagist-all-packages-schema branch February 24, 2023 06:23
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.152.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zharinov @renovate-release @viceice @rarkins