-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasource/helm): add digest to release #23432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, doesn't work like this.
Thanks for the response. I updated the snapshot to fix the test cases. Can you elaborate if this is not what you meant? This change allows the regex manager to also update the digest for a helm datasource. |
@viceice Hi, can you provide more details? These changes work in my local environment so not sure what is broken. My use case involves updating the version/digest of a helm archive within a bazel http_file rule. This PR adds the digest to the helm datasource so I can use it with a regex manager. The digest is in the index.yaml which is already parsed by the helm datasource, but is not captured since it is missing from the HelmRelease type. |
🎉 This PR is included in version 36.58.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
In renovatebot#23432 support was added for digests. This introduces a regression when used in combination with the Helm repository on Gitlab. In the `index.yaml` generated by Gitlabs Helm Repository the digest is left blank. For example: ``` apiVersion: v2 entries: blank-digest: - apiVersion: v2 created: '2023-09-05T13:25:19.046604000Z' description: A Helm chart with a blank digest digest: name: blank-digest urls: - https://charts.helm.sh/stable/packages/ambassador-2.7.0.tgz version: 2.7.0 ``` As a result `newDigest: release.digest` will set the `newDigest` to `null` and this causes the update to be removed in `workers/repository/process/lookup/index.ts`.
Changes
Add support for the digest of a chart archive within the helm datasource.
Context
discussion#23430
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: