-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(manager/poetry): use zod schema validation #23830
Conversation
Please update the branch, as we've merged Toml schema utils separately |
Please let me provide my own version of this refactoring. Code changes I want to ask for are quite big, so communication could take days. So please let me try to just refactor it on my own, hopefully you'll guys like it too. |
So do I still need to do anything for this PR? Or I’ll just close it and let you finish the refactoring? |
Please don't, just let me try to do the refactoring myself in another PR, and then you'll be able to work on your main goal |
Actually, let's make it another way. Let's merge your PR and I'll make one more refactoring on top of yours. |
Cool, I still want to work of the issue in this discussion #19144 I guess I’ll just wait for you to finish the changes first then? |
Yes, please |
🎉 This PR is included in version 36.52.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi @zeshuaro, sorry for long pause. Please, take a look at the current zod-based implementation. It's not complete, but maybe 70–80% of what I wanted to achieve. Are you still interested in working on your original problem? |
No problems, I actually already had a PR raised and merged which was then reverted due to some reported issues. There is a new PR raised to address the problem: #24335 |
Changes
Refactor to use zod schema validation for
poetry
managerContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: