Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(poetry): Use transforms for dependencies parsing #23965

Merged
merged 25 commits into from
Aug 25, 2023

Conversation

zharinov
Copy link
Collaborator

Changes

Apply more idiomatic approach for Zod schema usage

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov marked this pull request as draft August 21, 2023 07:30
@zharinov zharinov marked this pull request as ready for review August 21, 2023 07:30
@zharinov zharinov marked this pull request as draft August 21, 2023 11:06
@zharinov
Copy link
Collaborator Author

<!-- If this is your first pull request: sign the CLA with this GitHub app: https://cla-assistant.io/renovatebot/renovate -->
<!-- Make sure the `Allow edits and access to secrets by maintainers` checkbox is checked on this pull request. -->
<!-- Please read https://github.com/renovatebot/renovate/blob/main/.github/contributing.md before you create your pull request.-->

## Changes

<!-- Describe what behavior is changed by this PR. -->

## Context

<!-- Describe why you're making these changes if it's not already explained in a corresponding issue. -->
<!-- If you're closing an existing issue with this pull request, use the keyword Closes #issue_number. -->
<!-- If you're referencing an issue with this pull request, put it in a Markdown list like this: - #issue_number. -->

## Documentation (please check one with an [x])

- [ ] I have updated the documentation, or
- [ ] No documentation update is required

## How I've tested my work (please select one)

I have verified these changes via:

- [ ] Code inspection only, or
- [ ] Newly added/modified unit tests, or
- [ ] No unit tests but ran on a real repository, or
- [ ] Both unit tests + ran on a real repository

<!-- Do you have any suggestions about this PR template? Edit it here: https://github.com/renovatebot/renovate/edit/main/.github/pull_request_template.md -->

<!-- Please do not force push to your PR's branch after you have created your PR, as doing so forces us to review the whole PR again. This makes it harder for us to review your work because we don't know what has changed. -->
<!-- PRs will always be squashed by us when we merge your work. Commit as many times as you need in this branch. -->
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to many unrelated changes 😉

@zharinov zharinov marked this pull request as ready for review August 21, 2023 16:12
@zharinov zharinov requested a review from viceice August 21, 2023 16:27
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/poetry/extract.ts Show resolved Hide resolved
@zharinov zharinov requested a review from viceice August 21, 2023 17:12
viceice
viceice previously approved these changes Aug 21, 2023
@zharinov zharinov requested a review from rarkins August 22, 2023 07:19
@rarkins rarkins enabled auto-merge August 24, 2023 11:18
@rarkins rarkins added this pull request to the merge queue Aug 25, 2023
Merged via the queue into renovatebot:main with commit 95d3a1d Aug 25, 2023
34 checks passed
@rarkins rarkins deleted the refactor/poetry-dep-schemas branch August 25, 2023 07:50
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.58.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants