-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(poetry): Use transforms for dependencies parsing #23965
Merged
rarkins
merged 25 commits into
renovatebot:main
from
zharinov:refactor/poetry-dep-schemas
Aug 25, 2023
Merged
refactor(poetry): Use transforms for dependencies parsing #23965
rarkins
merged 25 commits into
renovatebot:main
from
zharinov:refactor/poetry-dep-schemas
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zharinov
commented
Aug 20, 2023
zharinov
commented
Aug 20, 2023
6 tasks
rarkins
reviewed
Aug 21, 2023
<!-- If this is your first pull request: sign the CLA with this GitHub app: https://cla-assistant.io/renovatebot/renovate --> <!-- Make sure the `Allow edits and access to secrets by maintainers` checkbox is checked on this pull request. --> <!-- Please read https://github.com/renovatebot/renovate/blob/main/.github/contributing.md before you create your pull request.--> ## Changes <!-- Describe what behavior is changed by this PR. --> ## Context <!-- Describe why you're making these changes if it's not already explained in a corresponding issue. --> <!-- If you're closing an existing issue with this pull request, use the keyword Closes #issue_number. --> <!-- If you're referencing an issue with this pull request, put it in a Markdown list like this: - #issue_number. --> ## Documentation (please check one with an [x]) - [ ] I have updated the documentation, or - [ ] No documentation update is required ## How I've tested my work (please select one) I have verified these changes via: - [ ] Code inspection only, or - [ ] Newly added/modified unit tests, or - [ ] No unit tests but ran on a real repository, or - [ ] Both unit tests + ran on a real repository <!-- Do you have any suggestions about this PR template? Edit it here: https://github.com/renovatebot/renovate/edit/main/.github/pull_request_template.md --> <!-- Please do not force push to your PR's branch after you have created your PR, as doing so forces us to review the whole PR again. This makes it harder for us to review your work because we don't know what has changed. --> <!-- PRs will always be squashed by us when we merge your work. Commit as many times as you need in this branch. -->
viceice
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to many unrelated changes 😉
viceice
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
viceice
previously approved these changes
Aug 21, 2023
viceice
reviewed
Aug 22, 2023
rarkins
approved these changes
Aug 24, 2023
🎉 This PR is included in version 36.58.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Apply more idiomatic approach for Zod schema usage
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: