Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: config option parent -> parents #26609

Merged
merged 14 commits into from
Jan 22, 2024
Merged

refactor: config option parent -> parents #26609

merged 14 commits into from
Jan 22, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

Change parent option to be an array of strings, and the associated changes

Context

Closes: #26599

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed Jan 14, 2024
View reviewed changes
lib/config/types.ts Outdated Show resolved Hide resolved
lib/config/validation.ts Outdated Show resolved Hide resolved
lib/config/validation.ts Outdated Show resolved Hide resolved
@RahulGautamSingh @viceice
Apply suggestions from code review
f1ab546 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins
rarkins reviewed Jan 21, 2024
View reviewed changes
lib/config/validation.ts Outdated Show resolved Hide resolved
rarkins
rarkins reviewed Jan 21, 2024
View reviewed changes
lib/config/validation.ts Outdated Show resolved Hide resolved
rarkins
rarkins requested changes Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please manually verify the diff in JSON schema and report it here

RahulGautamSingh and others added 3 commits January 21, 2024 18:30
@RahulGautamSingh
Merge branch 'main' into refactor/config-option-parent-to-parents
bdc46ef
@RahulGautamSingh @rarkins
Update lib/config/validation.ts
6618878 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@RahulGautamSingh @rarkins
Update lib/config/validation.ts
e1b76c6 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Jan 21, 2024 •
edited

Please manually verify the diff in JSON schema and report it here

There will no difference, since the parents haven't been modified.
Verified manually. I have posted the json schema generated from this branch here, it is the same though :)

rarkins
rarkins reviewed Jan 21, 2024
View reviewed changes
lib/config/validation.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Jan 21, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/config/types.ts Show resolved Hide resolved
lib/config/validation.ts Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Jan 21, 2024
View reviewed changes
@RahulGautamSingh @rarkins
Update lib/config/validation.ts
92d95b9 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@viceice viceice added this pull request to the merge queue Jan 22, 2024
Merged via the queue into renovatebot:main with commit d908ca3 Jan 22, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.142.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
@RahulGautamSingh @viceice
@rarkins @zT-1337
refactor: config option parent -> parents (renovatebot#26609)
a282e3d 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@RahulGautamSingh @viceice
@rarkins @zT-1337
refactor: config option parent -> parents (renovatebot#26609)
c0c5dc0 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@RahulGautamSingh @viceice
@rarkins @zT-1337
refactor: config option parent -> parents (renovatebot#26609)
3c81319 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: config option parent -> parents
4 participants
@RahulGautamSingh @renovate-release @viceice @rarkins