Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/pip-compile): Change fileMatch behaviour to target pip-compile output files #26858

Merged

Conversation

not7cd
Copy link
Contributor

@not7cd not7cd commented Jan 25, 2024

This is a breaking change, although this manager is in its alpha stage.
I'm looking for input regarding tests. I might revert use of commander.js as command parser, as this is a bit unorthodox.

Changes

Now package files are infered from command embeded in output file header. This should enable support for additional package managers that use files like setup.py, setup.cfg and those conforming to PEP 621.

Command extraction from header has been moved to common module, as it will be reused in lockedDependencyUpdate and other functions.

Context

See discussion: #24725 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Now package files are infered from command embeded in output file header. This should enable support for additional package managers that use files like setup.py, setup.cfg and those conforming to PEP 621.

Command extraction from header has been moved to common module, as it will be reused in lockedDependencyUpdate and other functions.
@not7cd not7cd changed the title feat(manager/pip-compile) Change fileMatch behaviour to target pip-compile output files feat(manager/pip-compile): Change fileMatch behaviour to target pip-compile output files Jan 25, 2024
@not7cd not7cd requested a review from rarkins January 26, 2024 14:07
Copy link
Contributor Author

@not7cd not7cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding failing tests, I suppose that there is an assupmtion of default command being returned by constructPipCompileCmd. I will look into this later.

@viceice viceice added the breaking Breaking change, requires major version bump label Jan 26, 2024
@not7cd not7cd requested a review from viceice January 26, 2024 17:45
@viceice viceice added the auto:no-done-comments Don't say "Done" or "Please review" - request a review instead label Jan 26, 2024
Copy link
Contributor

Hi there,

You are using done comments which cause a lot of noise. Instead, please use GitHub's web interface to request another review. Please read our contributing guidelines to reduce noise.

Good luck,

The Renovate team

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge main to remove the refactor changes from this PR 🤗

@not7cd not7cd requested a review from viceice January 26, 2024 22:06
@not7cd
Copy link
Contributor Author

not7cd commented Feb 12, 2024

I have created a migration based on all relevant fileMatch values found with this query.
https://github.com/search?q=%22pip-compile%22+AND+%22fileMatch%22+path%3A**%2Frenovate*&type=code&p=5

viceice
viceice previously approved these changes Feb 12, 2024
@rarkins rarkins removed breaking Breaking change, requires major version bump auto:no-done-comments Don't say "Done" or "Please review" - request a review instead labels Feb 12, 2024
rarkins
rarkins previously approved these changes Feb 12, 2024
@not7cd not7cd dismissed stale reviews from rarkins and viceice via 4c3f2ff February 12, 2024 18:06
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/config/migration.spec.ts Outdated Show resolved Hide resolved
@not7cd not7cd requested a review from viceice February 12, 2024 18:23
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@not7cd not7cd requested a review from viceice February 13, 2024 10:57
@rarkins rarkins added this pull request to the merge queue Feb 13, 2024
Merged via the queue into renovatebot:main with commit 2df7ef5 Feb 13, 2024
34 checks passed
@not7cd not7cd deleted the not7cd/pip-compile-fileMatch branch February 13, 2024 14:23
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.187.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants