feat(manager/pip-compile): Allow security updates for indirect dependencies #26871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now package files are infered from command embeded in output file header. This should enable support for additional package managers that use files like setup.py, setup.cfg and those conforming to PEP 621. Command extraction from header has been moved to common module, as it will be reused in lockedDependencyUpdate and other functions.
not7cd
force-pushed
the
not7cd/pip-compile-updateIndirect
branch
from
8fb8706
to
4d48432
Compare
Allow extraction and parsing but don't contruct command if custom
not7cd
force-pushed
the
not7cd/pip-compile-updateIndirect
branch
from
e8f4b8a
to
7588b6e
Compare
sigma67
reviewed
Feb 5, 2024
| ```json | ||
| { | ||
| "pip_requirements": { | ||
| "enabled": false |
There was a problem hiding this comment.
What if a repository uses both requirements.in for its main dependencies, and requirements.txt for say, docs/requirements.txt? This needs a better suggestion that allows using both at the same time. Does renovate support filepath exclusion for a manager?
There was a problem hiding this comment.
And massive thanks for your efforts to improve the pip-compile manager 🙌
There was a problem hiding this comment.
I plan to create support to support relative paths and other cases. Please see #26858, as this is the main PR, and this is a draft concerned with indirect deps.
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #26858, meanwhile review these commits https://github.com/renovatebot/renovate/pull/26871/files/1ecf6654ac63cb5fdafd54a90e3f3f7c38cd1b57..HEAD
Changes
Every extracted dependency gets assigned
lockedVersionfrom lock file. Warning is raised if there is no lock.If locked dependency is not present it is added to
PackageFileContentas indirectdepType.WIP, pass indirect deps to
updateLockedDependencyContext
#24725 (comment)
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: