Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reconfigure renovate #5725

Merged
merged 7 commits into from
Mar 16, 2020
Merged

chore: reconfigure renovate #5725

merged 7 commits into from
Mar 16, 2020

Conversation

viceice
Copy link
Member

@viceice viceice commented Mar 16, 2020

Add some regex managers to update the Dockerfile

@viceice viceice requested a review from rarkins March 16, 2020 07:16
@rarkins
Copy link
Collaborator

rarkins commented Mar 16, 2020

I would like to consider having a single manager and using comments above the env instead, what do you think?

Alternatively, I think these env vars are so common in Dockerfiles that we could make them presets and maybe even part of config:base

@viceice
Copy link
Member Author

viceice commented Mar 16, 2020

Yeah, working on it, will try it on docker composer image repo first

@viceice
Copy link
Member Author

viceice commented Mar 16, 2020

@rarkins Ready to review again.

@viceice
Copy link
Member Author

viceice commented Mar 16, 2020

same regex works for renovatebot/composer 💪

@rarkins
Copy link
Collaborator

rarkins commented Mar 16, 2020

Code suggestions is broken for me, so doing it as a comment here

Instead of # renovate: github-releases/docker/docker-ce&versioning=docker, do you think # renovate: github-releases/docker/docker-ce versioning=docker is cleaner? i.e. a space divider instead of &

@viceice
Copy link
Member Author

viceice commented Mar 16, 2020

Code suggestions is broken for me, so doing it as a comment here

Instead of # renovate: github-releases/docker/docker-ce&versioning=docker, do you think # renovate: github-releases/docker/docker-ce versioning=docker is cleaner? i.e. a space divider instead of &

What about:

# renovate: datasource=github-releases name=docker/docker-ce versioning=docker
ENV DOCKER_VERSION=19.03.5

or

# renovate: datasource:github-releases name:docker/docker-ce versioning:docker
ENV DOCKER_VERSION=19.03.5

@rarkins
Copy link
Collaborator

rarkins commented Mar 16, 2020

I like this approach best: # renovate: datasource=github-releases name=docker/docker-ce versioning=docker

My only doubt is whether to use depName and optionally lookupName for consistency

@viceice
Copy link
Member Author

viceice commented Mar 16, 2020

🤔 Ok, we can use wharever we want as key, because it's only relevant for regex matching, but the key will not be the capture group name by default. We would make it explicit. I'll try to update the regex.

@rarkins
Copy link
Collaborator

rarkins commented Mar 16, 2020

I think the simplest approach is to use the capture groups, and also plenty will probably copy from this repo's config to learn, so it can be good for consistency to have like depName=(<?depName>.*?)

@viceice
Copy link
Member Author

viceice commented Mar 16, 2020

see current changes

Dockerfile Outdated Show resolved Hide resolved
@rarkins rarkins merged commit 4883bb9 into master Mar 16, 2020
@rarkins rarkins deleted the chore/renovate branch March 16, 2020 14:33
@viceice
Copy link
Member Author

viceice commented Mar 16, 2020

Working, see #5728 💪

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants