-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reconfigure renovate #5725
Conversation
I would like to consider having a single manager and using comments above the env instead, what do you think? Alternatively, I think these env vars are so common in Dockerfiles that we could make them presets and maybe even part of config:base |
Yeah, working on it, will try it on docker composer image repo first |
@rarkins Ready to review again. |
same regex works for |
Code suggestions is broken for me, so doing it as a comment here Instead of |
What about: # renovate: datasource=github-releases name=docker/docker-ce versioning=docker
ENV DOCKER_VERSION=19.03.5 or # renovate: datasource:github-releases name:docker/docker-ce versioning:docker
ENV DOCKER_VERSION=19.03.5 |
I like this approach best: My only doubt is whether to use |
🤔 Ok, we can use wharever we want as key, because it's only relevant for regex matching, but the key will not be the capture group name by default. We would make it explicit. I'll try to update the regex. |
I think the simplest approach is to use the capture groups, and also plenty will probably copy from this repo's config to learn, so it can be good for consistency to have like |
see current changes |
Working, see #5728 💪 |
Add some regex managers to update the
Dockerfile