fix(cache): global cache init #6314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/datasource/docker/index.spec.ts # lib/datasource/github-releases/index.spec.ts # lib/datasource/github-tags/index.spec.ts # lib/datasource/gitlab-tags/index.spec.ts # lib/datasource/helm/index.spec.ts # lib/datasource/npm/index.spec.ts # lib/datasource/nuget/index.spec.ts # lib/datasource/orb/index.spec.ts # lib/datasource/packagist/index.spec.ts # lib/datasource/pod/index.spec.ts # lib/datasource/ruby-version/index.spec.ts # lib/workers/pr/changelog/index.spec.ts
This comment has been minimized.
This comment has been minimized.
viceice
reviewed
May 24, 2020
lib/util/cache/global/index.ts
Outdated
|
|
||
| function getGlobalKey(namespace: string, key: string): string { | ||
| return `global%%${namespace}%%${key}`; | ||
| } | ||
|
|
||
| export function get<T = any>(namespace: string, key: string): Promise<T> { | ||
| if (!initComplete) { |
There was a problem hiding this comment.
Simply test for global.renovateCache here, so you are able to override it in the app
There was a problem hiding this comment.
True, that's a better stepping stone. I plan to add Redis support here after this
There was a problem hiding this comment.
What about initialize renovateCache in this file init function and simply set global.renovateCache = fileCache ?
This reverts commit b5e1c53.
viceice
approved these changes
May 24, 2020
|
🎉 This PR is included in version 20.2.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the global file cache so that it is inactive unless initialized.