chore(eslint): fixing some eslint warnings #7382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
requested changes
Sep 30, 2020
viceice
reviewed
Oct 1, 2020
lib/datasource/packagist/index.ts
Outdated
| // istanbul ignore if | ||
| if (cachedResult) { | ||
| return cachedResult as Promise<AllPackages | null>; | ||
| return Promise.resolve(cachedResult); |
There was a problem hiding this comment.
I think cachedResultis already a Promise? 🤔
There was a problem hiding this comment.
Yes. I'm not super confident with returning the Promise instead of the content, but I'll fix the types on this one for now
viceice
reviewed
Oct 1, 2020
- `no-unused-vars` was commented out in favour of `@typescript-eslint/no-unused-vars`
- `@typescript-eslint/camelcase` was deprecated and replaced with `@typescript-eslint/naming-convention`
- `@typescript-eslint/no-floating-promises` is already enabled by default in `@typescript-eslint/recommended-requiring-type-checking`
Code changes are all related to `@typescript-eslint/no-unsafe-return`, and fixes any issues under `lib/workers`
JamieMagee
force-pushed
the
chore/eslint-fixes
branch
from
887bc41
to
b0fa1aa
Compare
viceice
approved these changes
Oct 5, 2020
|
🎉 This PR is included in version 23.42.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-unused-varswas commented out in favour of@typescript-eslint/no-unused-vars@typescript-eslint/camelcasewas deprecated and replaced with@typescript-eslint/naming-convention@typescript-eslint/no-floating-promisesis already enabled by default in@typescript-eslint/recommended-requiring-type-checkingCode changes are all related to
@typescript-eslint/no-unsafe-return, and fixes any issues underlib/workers