Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): fixing some eslint warnings #7382

Merged
merged 5 commits into from Oct 5, 2020
Merged

Commits on Oct 3, 2020

  1. chore(eslint): fixing some eslint warnings

        - `no-unused-vars` was commented out in favour of `@typescript-eslint/no-unused-vars`
        - `@typescript-eslint/camelcase` was deprecated and replaced with `@typescript-eslint/naming-convention`
        - `@typescript-eslint/no-floating-promises` is already enabled by default in `@typescript-eslint/recommended-requiring-type-checking`
    
        Code changes are all related to `@typescript-eslint/no-unsafe-return`, and fixes any issues under `lib/workers`
    JamieMagee committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    50ef82e View commit details
    Browse the repository at this point in the history
  2. test fixes

    JamieMagee committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    0c1013f View commit details
    Browse the repository at this point in the history
  3. pr review comments

    JamieMagee committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    7c7c088 View commit details
    Browse the repository at this point in the history
  4. fix cache types

    JamieMagee committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    b0fa1aa View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Configuration menu
    Copy the full SHA
    44bc871 View commit details
    Browse the repository at this point in the history