Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config update #51

Merged
merged 7 commits into from
Feb 13, 2020
Merged

Config update #51

merged 7 commits into from
Feb 13, 2020

Conversation

tok-kkk
Copy link
Member

@tok-kkk tok-kkk commented Feb 13, 2020

  • Update config format to the latest version in darknode.
  • Remove --config flag form the update command to avoid conflicts in the config file.
  • Show messages to tell if nodes have successfully been started/stopped/restarted.
  • Minor tweak with the darknode installation script.
  • Fix incorrect bootstrap addresses on testnet and devnet.

@tok-kkk tok-kkk added the feature New feature or request label Feb 13, 2020
@tok-kkk tok-kkk self-assigned this Feb 13, 2020
jazg
jazg requested changes Feb 13, 2020
View reviewed changes
Copy link
Member

@jazg jazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor comments/messaging tweaks to be made before we can release it.

cmd/down.go Outdated Show resolved Hide resolved
cmd/down.go Outdated Show resolved Hide resolved
cmd/down.go Outdated Show resolved Hide resolved
cmd/down.go Outdated Show resolved Hide resolved
cmd/down.go Outdated Show resolved Hide resolved
cmd/down.go Outdated Show resolved Hide resolved
cmd/down.go Outdated Show resolved Hide resolved
cmd/down.go Outdated Show resolved Hide resolved
cmd/flag.go Outdated Show resolved Hide resolved
cmd/switch.go Outdated Show resolved Hide resolved
@tok-kkk tok-kkk merged commit 44b980f into release/v3.0.5 Feb 13, 2020
@tok-kkk tok-kkk deleted the feat/config-update branch February 13, 2020 05:31
@tok-kkk tok-kkk mentioned this pull request Feb 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazg jazg jazg approved these changes

Assignees

@tok-kkk tok-kkk

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tok-kkk @jazg