-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TTL pruning logic #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loongy
previously approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have left one question and one comment, but nothing that would prevent this from being merged.
loongy
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two issues with the pruning logic.
Data is divided into slots (current time / length of interval) which represent discrete time intervals. These slots are dropped when their distance is >= 1 from the current time slot. This means if data is inserted at the start of a slot and at the end, they will both be pruned when the next slot is created.
Inserting data with the same key does not update the time at which the data will be pruned. For example (assuming we have one hour prune intervals), if the user inserts data at 3pm and updates the data at 3:30pm, the pruning still occurs at 4pm since the key has not changed.
This PR does two things to fix these issues.
Increases the distance from 1 to 2. So (assuming the prune interval is one hour) rather than pruning data that is at most 1 hour old, it is pruned after at least 1 hour and at most 2 hours.
Removes the key from the previous slot when the data is updated.