Fix frozen programs crash due to missing json import #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r) would hang with a json import error. I also added similar import statements for the render module for completeness, since they seemed to be missing.
|
This is for issue #94. |
|
I added these 4 lines to my local pygame_sdl2 code and can confirm that it does indeed resolve the PyInstaller crash (related to missing JSON import) in Windows! Good job! This should be brought into the main code set, unless it's creating some conflict somewhere else. |
|
Closing this, as building pygame_sdl2 outside of Ren'Py is no longer supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to freeze a pygame_sdl2 program right now using PyInstaller you get a crash on windows (and presumably other platforms) with a json import error. Adding an 'import json' fixes this crash and lets pygame_sdl2 support PyInstaller.
While I was in here I added two lines of optional imports for the render module in the same pattern as the other optional import modules - since they seemed to be missing. These are not essential to fix the crash and can be removed if they aren't wanted for some reason.