Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitely close audio on quit #1639

Merged
merged 1 commit into from Nov 16, 2018
Merged

Explicitely close audio on quit #1639

merged 1 commit into from Nov 16, 2018

Conversation

@Beuc
Copy link
Contributor

@Beuc Beuc commented Nov 15, 2018

With Emscripten, this tells the browser to stop calling the audio callback.

With Emscripten, this tells the browser to stop calling the audio callback.
@renpytom renpytom merged commit 3f474a4 into renpy:master Nov 16, 2018
@renpytom
Copy link
Member

@renpytom renpytom commented Nov 16, 2018

Seems harmless. Merged.

@renpytom
Copy link
Member

@renpytom renpytom commented Nov 16, 2018

And of course, it prevented normal Ren'Py from closing. Reverted until after 7.1.2.

@Beuc
Copy link
Contributor Author

@Beuc Beuc commented Nov 16, 2018

It looks like renpy.audio.audio.quit() was never used before, and contains a logic error.
I'm sending another PR.

@Beuc Beuc deleted the Beuc:patch-1 branch Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants