New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitely close audio on quit #1639

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@Beuc
Contributor

Beuc commented Nov 15, 2018

With Emscripten, this tells the browser to stop calling the audio callback.

Explicitely close audio on quit
With Emscripten, this tells the browser to stop calling the audio callback.

@renpytom renpytom merged commit 3f474a4 into renpy:master Nov 16, 2018

@renpytom

This comment has been minimized.

Member

renpytom commented Nov 16, 2018

Seems harmless. Merged.

@renpytom

This comment has been minimized.

Member

renpytom commented Nov 16, 2018

And of course, it prevented normal Ren'Py from closing. Reverted until after 7.1.2.

@Beuc

This comment has been minimized.

Contributor

Beuc commented Nov 16, 2018

It looks like renpy.audio.audio.quit() was never used before, and contains a logic error.
I'm sending another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment