Remove bin/fastcheck from bin/check script
#361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasbischof
commented
Mar 22, 2024
ruby_on_rails/app_initialisation.md
Outdated
| @@ -58,7 +58,7 @@ They are always idempotent (runnable multiple times). | |||
| * Add a `bin/check` file. It will run all the automated tests. It's mainly used in our CI. | |||
|
|
|||
| ```sh | |||
| echo "#\!/usr/bin/env bash\nset -euo pipefail\nbin/fastcheck\nbin/rails zeitwerk:check" > bin/check | |||
| echo "#\!/usr/bin/env bash\nset -euo pipefail\n\nbin/rails zeitwerk:check" > bin/check | |||
There was a problem hiding this comment.
I think a double new line increases readability and we also have it this way in other projects as well (e.g. mtextur, remms)
lukasbischof
force-pushed
the
feature/update-bin-check-template
branch
from
a6ba35f
to
90f6159
Compare
rnestler
approved these changes
Mar 22, 2024
I also like this naming better than fastcheck (in my opinion, fastcheck is a bad name as it's not apparent what it does, especially in presence of a check script. The name suggest that it just runs the tests faster but actually it does not run any tests at all). However, this would either produce different namings in newer projects or a lot of pull requests moving a file |
coorasse
approved these changes
Mar 22, 2024
|
Agree! I am also in favor of renaming, but let's move on with this change in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing
bin/fastcheckinbin/checkcauses it to be executed twice on the CI and thus increasing CI time. In some projects, this was already removed. We should do the same for all other projects as well to keep it consistent and fast