Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth volume not changing #83

Closed
mase76 opened this issue Apr 11, 2018 · 24 comments
Closed

Bluetooth volume not changing #83

mase76 opened this issue Apr 11, 2018 · 24 comments
Labels
enhancement Proposal for enhancing existing functions

Comments

@mase76
Copy link

mase76 commented Apr 11, 2018

Hi!
The (bluetooth) media volume does not change. I have set up to change the media volume to full when connecting to my car stereo. However the profile is loaded. All permissions are set. My system is Omnirom 8.1.0.

@renyuneyun
Copy link
Owner

Thanks for reporting.
I'll fix this soon.

(Note to myself)
STREAM_BLUETOOTH is not documented, but Android is using 6 for it (see https://stackoverflow.com/questions/4472613/android-bluetooth-earpiece-volume ).

@renyuneyun renyuneyun added the enhancement Proposal for enhancing existing functions label Apr 12, 2018
@renyuneyun renyuneyun added this to v0.5.7 in v0.5-v0.6 Apr 23, 2018
v0.5-v0.6 automation moved this from ~v0.5.7 to Done Apr 24, 2018
@renyuneyun
Copy link
Owner

This should have been solved in v0.5.7 (which should appear anytime on f-droid).

Feel free to reopen this issue if it's still there.

@mase76
Copy link
Author

mase76 commented Apr 28, 2018

No, bt volume does not change here with 0.5.7.
Maybe a look into the app would help:
https://github.com/jroal/a2dpvolume
BT volume changing works there.

@renyuneyun
Copy link
Owner

Just to confirm: are you using (in the new version) the "bluetooth" volume meter?
It's a separate meter, added in v0.5.7

@mase76
Copy link
Author

mase76 commented Apr 28, 2018 via email

@renyuneyun
Copy link
Owner

My fault...
I forgot to put the line which changes bluetooth volume...

I have fixed in the code, and the fix will appear in next release (v0.5.7.1 I think).

Anyway, thanks for reporting!

@mase76
Copy link
Author

mase76 commented Apr 30, 2018 via email

@renyuneyun renyuneyun reopened this May 4, 2018
v0.5-v0.6 automation moved this from Done to TO DO ~v0.6 May 4, 2018
@renyuneyun
Copy link
Owner

They seem to be using the same one (and there is nothing to do with the new "bluetooth volume" I added in v0.5.7.1)...
Just to confirm: have you tried to treat "music volume" as bluetooth volume (when connected to bluetooth)?

@mase76
Copy link
Author

mase76 commented May 5, 2018

Yes, I used bt volume, not music volume.

@renyuneyun
Copy link
Owner

renyuneyun commented May 5, 2018 via email

@mase76
Copy link
Author

mase76 commented May 5, 2018 via email

@renyuneyun
Copy link
Owner

Hmm, thanks for the info!

So the solution is simple adding a delay. That's why I don't see that since in my test I use "charge" as the trigger and bluetooth headset is always connected.

There are two solutions, but I'm not sure which one you (and/or other people) would prefer:

  1. Keep only the "music" field, and tell the user they'll need to add a delay (which is possible in Easer, through chained events) if want to set bluetooth volume, and let them do that manually. This gives user more control, and is visible in the future (when a graph is used to show the relationship of those triggers).
  2. Add a "bluetooth music" field, and silently wait for a few seconds (maybe configurable) to adjust the volume, and user is responsible to choose the correct one ("bluetooth music" or "music" [or both, but doesn't make sense]).

By the way, let me check: is "music" the only volume setting which will vary/change between bluetooth and non-bluetooth?

@mase76
Copy link
Author

mase76 commented May 5, 2018 via email

@mase76
Copy link
Author

mase76 commented May 7, 2018

With the delay option it works fine now.

@renyuneyun
Copy link
Owner

That's great.
Maybe this issue can be closed?

@mase76
Copy link
Author

mase76 commented May 8, 2018

Yes, I think, it can be closed.
But I would suggest to add the delay option generally to the volume change, independent
from bluetooth. When the delay is not needed, it can be set to 0.

@mase76 mase76 closed this as completed May 8, 2018
v0.5-v0.6 automation moved this from TO DO ~v0.6 to Done May 8, 2018
@renyuneyun
Copy link
Owner

Not sure if I understand you correctly: do you suggest to "move" the delay to the whole "volume" setting (in one Profile)?

@mase76
Copy link
Author

mase76 commented May 12, 2018

Yes, so the delay can be set when needed, independent from the volume channel.

@renyuneyun
Copy link
Owner

Then I think it's better to chain a "delay"/"timer" event and set the volume there.

The reason why I prefer this way is because I'm planning to add a "visual graph" for the scripts (yes, the previously UI element called "event" is renamed to "script"), and the delay can be easily seen there.

@mase76
Copy link
Author

mase76 commented May 13, 2018 via email

@mase76
Copy link
Author

mase76 commented May 23, 2018

I don't know what happened. Since a few days, the bt volume changes not to the prefered value. When I configure full volume, I get only about 60%. When I set half, I get only about 30%. The action itself works, including the delay.

@mase76 mase76 reopened this May 23, 2018
v0.5-v0.6 automation moved this from Done to TO DO ~v0.6 May 23, 2018
@renyuneyun
Copy link
Owner

The order of elements are changeable, at least from what I understand. Maybe you are experiencing some problem related to the old unclear semantics (of Event/Scenario), but this should be solved when all suitable Events have been transferred to Conditions (,which is not yet happened, but is happening).

For the volume, I think this may be a result of using different metrics, and BT has a different "highest" value than non-BT volume. I think the only solution is to use percentage...

@mase76
Copy link
Author

mase76 commented May 26, 2018 via email

@renyuneyun renyuneyun added this to To Do in v0.6-v0.7 May 26, 2018
@renyuneyun
Copy link
Owner

I'm closing this as the issue seems to be fixed.

Feel free to reopen it :)

v0.5-v0.6 automation moved this from TO DO ~v0.6 to Done Sep 17, 2018
v0.6-v0.7 automation moved this from To Do to Done Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposal for enhancing existing functions
Projects
No open projects
v0.5-v0.6
  
Done
v0.6-v0.7
  
Done
Development

No branches or pull requests

2 participants