-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update milkdown editor to use v7 and get indentations for free #99
Conversation
This is great...Although it looks the upgrade has meant it no longer picks up the styles in global.css. Do you think you could bring back that styling? |
Brought back, with a little extra update to the URL color that was just killing me. Note that the block editor view now doesn't support translation between types (eg from unordered list to codeblock, presumably because it would be quite hard to translate between the two types, especially with indentation. Nothing we can do about that except submit a plugin update, but I think that the update to get indentation is probably more important than the ability to hot swap format types. |
Referenced issue to build our own bullet point view - Milkdown/milkdown#991 Fixing the missing todos - requires us to dynamically render the view by using the prosemirror's |
ctx.get(listenerCtx).markdownUpdated((_ctx, markdown) => { | ||
debounce(() => { | ||
setContent(markdown); | ||
}, 1000)(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this made my own typing experience improve slightly
b2066b6
to
41a6db8
Compare
d65d81c
to
98fe3bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
update milkdown editor to use v7 and get indentations.
Upgraded Milkdown to v7, includes indentation by default, which was sorely lacking for a while now and a key feature of OrgMode.
Indentation.with.v7.mov