Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing PSTR() #763

Closed
Nibbels opened this issue Mar 13, 2018 · 2 comments
Closed

Missing PSTR() #763

Nibbels opened this issue Mar 13, 2018 · 2 comments

Comments

@Nibbels
Copy link

Nibbels commented Mar 13, 2018

Repetier-Firmware/src/ArduinoAVR/Repetier/gcode.cpp

Line 1171 in 652d86a

Com::printErrorFLN("Checksum required when switching back to ASCII protocol.");

Is there a PSTR() missing around "Checksum required when switching back to ASCII protocol." ?

Greetings
@Nibbels Nibbels mentioned this issue Mar 13, 2018
Closed
Nibbels added a commit to Nibbels/Repetier-Firmware that referenced this issue Mar 13, 2018
@Nibbels
fixing missing PSTR and possible other communication bug
a7f0eb4 
repetier#763
@repetier
Copy link
Owner

Yes. it is required. Thanks.

Nibbels added a commit to RF1000community/Repetier-Firmware that referenced this issue Apr 2, 2018
@Nibbels
New Stable 1.41.xx (#136)
2a7ac11 
* milling mode: reduced minimum step size for work part scan to 5mm (needed for better precision e.g. when milling PCBs)

* 1.37x9

* fix config

* Update G-Startcode Simplify3D RFx000 linker Extruder - SenseOffset Strategie.txt

* Small cleanup

* "X max lengh" amnesiefix für RF2000

* lower Homing feedrate

Thx @RF1000 -Conrad
Lower noise and more smooth operation  while homing

* 1.37y ZOS HBS Scangüte Testversion

Vereinheitlichung der Variablen beim MoveZ usw.
Kleine Fixes
Kleine Deletions

* 1.37y_fix

respect full interval back move

* Update to RF1.39 fixes

- Added V3 Hotend (possible wrong pid values!)
- Added definitions for RF2000v2 and PIN mapping (final??)
- Replaced PT100 with V3 Hotends 3950 100k type, because Renkforce chose that number
- some more ifdef Feature_Pause_Printing marks.
- moved menu sensor type from 14 to 13 to have V3 support by menu
- added PRINTER_FLAG2_RESET_FILAMENT_USAGE
- some minor code cleanup
- added M3076 code
- added checks for deleting zmatrix while CMP
- RF1000s fix for loadCompensationMatrix without milling mode

* 1.37z fixes

* 1.37z eeprom supp for M3076

* 1.37z2

* 1.37z2 change

* 1.38

* 1.38.Mod

* removed temptable 14, dropped 15 in.

* added Feature Align Extruders from Renkforce 1.39

* config fix

* add countdown to PLA/ABS Scan (renkforce 1.39)

* feedrate cleanup / g_uBlockSDCommands+g_uStopTime check / milling stuff

* ZCMP-E-Compensation

test commit

* 1.38.03

improved E compensation while z compensation at borders.

* theoretical fix

* fan speed menu improved

@atlonxp as tester

* 1.38.05

bessere testzwischenversion

* RF.01.38.05.Mod ZCMP OFF-Fix

* RF.01.38.07.Mod testversion

* 1.38.08 addFloat fix

* less fankickstart

* Update CMakeLists.txt

An dieser Stelle fehlt das "=" zeichen weshalb Cmake build failed!

* Revert "Update CMakeLists.txt"

* better PID help

* 1.38.09

* cmake test and rf2000v2 def upgrade

* fix

* fix

* cmake test

* cmake test options

* revert, didnt work. use sed!

* 1.38.10.Mod

added a feature to test homing

* 1.38.11

* sync gcode to repetier

plus some tiny fixes

* version

* send better readable log message if Heat Bed Scan fails because of endstop limit Z_ENDSTOP_DRIVE_OVER

* more beauty for some syntax

* Fix Tyreus Lyben was not used but No Overshoot

Thx @repetier for telling me

* press buttons by gcode test

M3029

* activate M3029 for autocompile

* uncached chars fix

* > fix

* charthings

* new startscreen for mod

* init fix, removed heatmanagers

* typo

* better nProcess

* use anyHomeDir in home functions instead of copied code

* cleanup of homing code

* small no milling mode compile fix

* ascii parse fixes from repetier

* removed formaterrors because they are not used anywhere

* autotune method description comment

* comment for PID algorithm

* 1.38.18

* tabs

* 1.38.19

* 1.38.20

* 1.38.21 autostartmade / livespeedchange

* small changes 1.38.22

* code cleanup

* possible ZOS-Fix for driving digits

* 1.38.24

* digit flow speed change only for queue

* 1.38.25

see changelog

* cleanup

* cleanups

* cleanup

* 1.38.26

* reinsert: unhome z weil zCMP ausgeschaltet werden muss.

* pure cleanup

* 1.38.27

* display size fix

* version

* lengthMM fix 1.38.28

* insert flow to auto startline

* 01.38.30 a lot of cleanup, small fixes

* cleanup

* 01.38.31

* 1.38.32 hbs improved

* 1.38.33

* some cleanup efforts

* some clearup work

* small bug in setTemperatureForAllExtruders

* small fix for only 1 extruder

* 1.38.34

* testfixes

* 1.38.35

* better menu support for MAX_FEEDRATE_X _Y _Z

* version

* removed wait from fan speed

* easygo25 sd-output-fix (in testing)

* removed "home z only"

* comments and research

* removed bogus check from ZOS

* removed all queuePositionCurrentSteps[E_AXIS]

* hbs tolerance improvement

* 1.38.39

* 01.38.39

* 1.39 testrelease

* some 3+Extrudercode cleanup

* update changelog

* fix waitForTargetTemperature

* hbs temp rise/fall display fix

* hbs temp wait adjustment

* respect g_uStartOfIdle within waitForTargetTemperature

* readme

* ) typo

* small tweaks and one update

* 1.41.00 alpha for unchained microstepping

unchained microstepping
unchained steps/mm
de-const-configuration
speed sync direct steps
some more detail patches

* Adjust OUTPUT_OBJECT_SCRIPT to standard homing speeds

* Adjust OUTPUT_OBJECT_SCRIPT to standard homing speeds

* raised unmount temp/always do G92 E0 after MOUNT/UNMOUNT

- because some materials are still stuck at 120°C
- because EMOVE without G92 E0 can be rolled back depending on next startcode.
- sync mount and unmount speeds+distance between RF1000 and RF2000

* 1.41.01

* 01.39.01+

* 1.41.03

* 1.41.03+

* commenting

* 1.41.04 +FEATURE_DEBUG_MOVE_CACHE_TIMING

* details / config

* 1.41.05

* deleted 2 unused functions

Printer::moveTo
Printer::resetDirectPosition

* deleted FEATURE_M42_TEMPER_WITH_PINS

* cleanup

* cleanup2

* tweaks

* fixing missing PSTR and possible other communication bug

repetier#763

* saving eeprom space

* 1.41.06

* 1.41.06 support for REPETIER_PROTOCOL:3

* renaming and cleanup

* noints to homing.

maybe not needed but cannot test.

* RF.01.41.07

* 1.41.08

* uid. cleanup

* 1.41.09

* kleiner Digitpatch für M3913 / M3914

* 1.41.10

* removed some double code

* microsteps do now update when configuration defaults

+ alot of cleanup

* prepare merge for 1.41

* removed extra ) which prevented compiling the firmware for RF1000

* added PT100 / sensor code update

* 1.41.13

* 1.41.14 autotune menu prettyfy

* 1.41.15

eeprom and menu support for scan start lift.

* 1.41.16

* 1.41.17

show which sensor fails ons sensor fail
@Nibbels
Copy link
Author

Nibbels commented May 10, 2018

5e13879#diff-8dd44db9d0e927c0e0b17d72fd8158ebL1171
You already fixed and published it.

Therefore I close this Issue.

Thx!!

@Nibbels Nibbels closed this as completed May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@repetier @Nibbels