Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUN-861 - Pause.getObjectPreview and fix ObjectId #258

Merged
merged 37 commits into from
Dec 7, 2022
Merged

RUN-861 - Pause.getObjectPreview and fix ObjectId #258

merged 37 commits into from
Dec 7, 2022

Conversation

Domiii
Copy link

@Domiii Domiii commented Dec 6, 2022 •
edited

  • big refactoring action: distinguish ccp* from rrp* ids/objects etc.
  • Add node to Pause.getObjectPreview

NOTE: I need to learn how to squash commits...

https://linear.app/replay/issue/RUN-861

@Domiii
first version of dynamic JS injection + DOM commands
d8defdd
@Domiii
error handling for CDP sendMessage calls + async tryEvalDev
e3bafc6
@Domiii
working on DOM id management
045cc64
@Domiii
more DOM id management
04cb54b
@Domiii
first version of DOM picker now "kinda" working in simple scenarios
0f9e18b
@Domiii
using ScriptWrappable::RecordReplayId for blink object ids
dc4dd97
@Domiii
change "BlinkObject" to "APIObject" + figure out DOM.getDocument
bea846b
@Domiii
separate getAPIObjectIdRaw from BuildDOMObjectForNode
24314ae
@Domiii
Session.findMouseEvents now working
95f52a0
@Domiii
work toward Pause.getObjectPreview
863e862
@Domiii
slowly figuring out arbitrary objectId mapping + implementing `getO…
0b520ca 
…bjectPreview`
@Domiii
more work on GetObjectIdForBlinkObject and `jsPreviewBlinkObjectFor…
ed7a258 
…ObjectId`
@Domiii
WIP: GetObjectIdForBlinkObject
618a5e1
@Domiii
jsGetObjectIdForAnyObject now working
5ae456a
@Domiii
remove my logs
d3af4bb
@Domiii
Merge branch 'master' of https://github.com/replayio/chromium into fe…
84cf000 
…ature/DOM-commands
@Domiii
hopefully fix wrong objectId issue (glyphs appear in objectId; li…
bbd1400 
…kely a result of a memory issue)
@Domiii
Eliminate unnecessary protocolId
451d224
@Domiii
fix wrapObjectGetObjectId dangling pointer
31d67b0
@Domiii
remove node from preview for now, so it won't show indefinite "Load…
d9199ec 
…ing..." message
@Domiii
added makeDebuggeeValue
e468dfd
@Domiii
more work on makeDebuggeeValue
4801627
@Domiii
remove unused code snippets
9fd8982
@Domiii
big renaming/refactoring of gReplayScript object management
dc24555
@Domiii
fixing refactored object and id tracking
2671109
@Domiii
basic previewBlinkObject
07718ae
@Domiii
fix makeDebuggeeValue and blink preview basics
fe7beea
@Domiii
fix duplicate rrpId issue (for now)
6398a3f
@Domiii
remove gLastCommandErrors
fbb71cb
@Domiii
Remove DevOnly
5176637
@Domiii Domiii self-assigned this Dec 6, 2022
@Domiii Domiii merged commit b28a02b into master Dec 7, 2022
@Domiii Domiii deleted the feature/RUN-861-getObjectPreview branch December 7, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannanvijayan kannanvijayan kannanvijayan left review comments

@bhackett1024 bhackett1024 bhackett1024 approved these changes

@loganfsmyth loganfsmyth Awaiting requested review from loganfsmyth

@hbenl hbenl Awaiting requested review from hbenl

Assignees

@Domiii Domiii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Domiii @bhackett1024 @kannanvijayan