Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implement Replay Tour MVP (#8852)" #8946

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Revert "Implement Replay Tour MVP (#8852)" #8946

merged 1 commit into from
Mar 16, 2023

Conversation

jcmorrow
Copy link
Contributor

This reverts commit aafc80d.

@vercel
Copy link

vercel bot commented Mar 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
devtools ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 4:17AM (UTC)

@qa-wolf
Copy link

qa-wolf bot commented Mar 16, 2023

Copy link
Contributor

@jonbell-lot23 jonbell-lot23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@replay-io
Copy link

replay-io bot commented Mar 16, 2023

E2E Tests

58 replays were recorded for 8c9677d.

image 4 Failed
    cypress-01: Test basic cypress reporter functionality
          ```
          expect(received).toHaveCount(expected) // deep equality
          
          Expected: 1
          Received: undefined
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/45f09d93-4f1a-4907-87fa-4a9585358fb1>breakpoints-03: Test stepping forward through breakpoints when rewound before the first one</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/7a74e578-5da4-4e88-9659-18fc7fa944a9>node_logpoint-01: Basic node logpoints</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/20b6faf5-113b-4974-834a-3eabe7d51a0c>sourcemap_stacktrace: Test that stacktraces are sourcemapped</a></summary>
        <ol type="1">
          
          ```
          expect(received).toEqual(expected) // deep equality
          
          - Expected  - 9
          + Received  + 1
          
          - Array [
          -   "App.js:9",
          -   "App.js:33",
          -   "regeneratorRuntime.js:44",
          -   "regeneratorRuntime.js:125",
          ```
        </ol>
      </details>
      
image 54 Passed
  • breakpoints-01: Test basic breakpoint functionality
  • breakpoints-02: Test unhandled divergence while evaluating at a breakpoint
  • breakpoints-05: Test interaction of breakpoints with debugger statements
  • breakpoints-06: Test log point in a sourcemapped file
  • breakpoints-07: rewind and seek using command bar and console messages
  • breakpoints-08: should be temporarily disabled
  • console_async: support console evaluations in async frames
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/c11c7138-8a87-42b7-b737-8dbb5266809f>console_dock_node: Should show the correct docking behavior for recordings without video</a></li>
      <li><a href=https://app.replay.io/recording/39d3e947-8a0b-4e54-973b-09c080c26201>console_dock: Should show the correct docking behavior for recordings with video</a></li>
      <li><a href=https://app.replay.io/recording/e97e0734-2ac0-4354-8131-bb97201f3626>console_errors: Test that errors and warnings from various sources are shown in the console</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/29087174-68e5-49bc-8bdf-1b8632e0e14e>console_eval: support console evaluations</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/c15aba39-17a3-4d87-a5cd-0d4c06f56851>console_warp-01: should support warping to console messages</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/8726feb6-2d79-4b46-be9b-4084beda95e4>console_warp-02: support pausing, warping, stepping and evaluating console messages</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/419dc8b0-25c3-4a42-8bd4-7d107ae7db32>console-expressions-01: should cache input eager eval and terminal expressions per instance</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/ea338f55-c1b5-47d1-b8fb-f9ab6f492250>focus_mode-01: should filter messages as regions based on the active focus mode</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/756579ad-782e-4b47-aa06-fdebb289fe75>highlighter: element highlighter works everywhere</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/dab6ffbb-7091-4f18-b727-b8c41626ea22>inspector-01: Test that scopes are rerendered</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/12caf9ce-0fb9-4b3d-a26b-33453cd85b08>inspector-02: element picker and iframe behavior</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/aeb279c2-a97e-48ef-96fc-953dc429d8b7>inspector-03: Test that styles for elements can be viewed</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/3fc42d09-b74f-46ad-99df-4ab11acf0c5e>inspector-04: Test that styles for elements can be viewed</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/438d10a7-0f94-46a9-8e52-183ec3b222b0>inspector-05: Test that styles for elements can be viewed</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/ce37820e-bb89-419f-bbd4-3c7cd9b3c13a>inspector-06: Test that styles for elements can be viewed</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/d5409363-9862-42a9-8768-b1af47b16fd0>inspector-07: Test that styles for elements can be viewed</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/8453d5d2-4ee0-4f74-84c8-dae3221caa5a>logpoints-01: log-points appear in the correct order and allow time warping</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/d243932f-7a6f-4106-bdeb-fc70888ec280>logpoints-02: conditional log-points</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/441d25bc-876e-46cc-acf4-5d5992916775>logpoints-03: should display event properties in the console</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/c33c982b-9c0a-4ad6-a2c9-5fd8cc2902d8>logpoints-04: should display exceptions in the console</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/d15774ea-3bb2-43af-8072-2ffe750711cf>logpoints-05: should auto-complete based on log point location</a></summary>
        <ol type="1">
          
          ```
          expect(received).toContain(expected) // indexOf
          
          Expected value: "arrayGlobal"
          Received array: []
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/8c7740ce-a692-44b7-8c82-0a590b366f0d>logpoints-06: should be temporarily disabled</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/ef45f808-fc6d-4501-af5f-9404a76b8f04>logpoints-07: should use the correct scope in auto-complete</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/e7e20ee3-04b5-4cc3-acff-0991ecfe0690>logpoints-08: should support jumping directly to a hit point via the capsule input</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/7888ce16-853c-4b0c-a3b6-96366e846cfa>node_console-01: Basic node console behavior</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/65c6f199-ce97-4c0c-9d5b-cd774fde9376>node_console-02: uncaught exceptions should show up</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/2c75984b-d96e-4af0-b0d6-e96dbed643e7>node_logpoint-02: Node exception logpoints</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/3b5a94a5-0065-4096-945e-0fbcba4cd52a>node_object_preview: Showing console objects in node</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/c67f5a53-4de7-4ebf-97b3-d362d1c8f520>node_spawn: Basic subprocess spawning</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/1e63b098-5d78-4a55-b52e-b965ffdee3d4>node_stepping-01: Test stepping in async frames and async call stacks</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/4eba77b0-6c49-4523-994d-2fdd41324a38>node_worker-01: make sure node workers don't cause crashes</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/33741f93-7f63-4130-af33-dd3ef1154b71>object_preview-01: expressions in the console after time warping</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/386c199c-a4cf-4767-a54e-2e61c08ec4c8>object_preview-02: should allow objects in scope to be inspected</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/dd3f9a31-e4d1-4fbe-a897-4d6f7e060369>object_preview-03: Test previews when switching between frames and stepping</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/8504adea-18cc-4e04-93af-a5b2a8de899c>object_preview-04: Test scope mapping and switching between generated/original sources</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/9555e8f4-d53a-4549-9291-e2e350d0da6f>object_preview-05: Should support logging objects as values</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/44165cdf-17e2-4d99-8f56-2dadc7350b0b>react_devtools: Test React DevTools.</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/569eef9b-d90c-42d0-a072-890b6c510b08>repaint: repaints the screen screen when stepping over code that modifies the DOM</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/0be274f8-03f0-4c0b-b36c-831ae6a3308f>resizable-panels-01: Left side Toolbar should be collapsible</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/58f89457-bf17-434d-a753-6f77d4008489>scopes_rerender: Test that scopes are rerendered</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/6e943960-8003-4769-a5f7-411c5a96b411>stacking: Element highlighter selects the correct element when they overlap</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/8c159bb7-f4e9-4da9-888c-925dad3b3004>stepping-01: Test basic step-over/back functionality</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/23c134d0-1c75-4863-ade2-b3c18eaeaaa7>stepping-02: Test fixes for some simple stepping bugs</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/c17ac1df-83f6-4620-b51a-56039c13aebc>stepping-03: Stepping past the beginning or end of a frame should act like a step-out</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/3dc1d656-63ab-4635-9ca3-dd59d7449a14>stepping-04: Test stepping in a frame other than the top frame</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/bebb52ad-9919-4252-adab-ec4cac21eda7>stepping-05: Test stepping in pretty-printed code</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/46afd723-5e9d-4d1e-9057-1508c0022087>stepping-06: Test stepping in async frames and async call stacks</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      

View test run on Replay ↗︎

Snapshot Tests

1 replays were recorded for 8c9677d.

image 1 Failed
    should handle too many points to find
          ```
          locator.getAttribute: Timeout 5000ms exceeded.
          =========================== logs ===========================
          waiting for selector "[data-test-id=PointPanel-68] >> [data-test-name=BadgePickerButton]"
          ============================================================
          ```
        </ol>
      </details>
      
image 0 Passed

View test run on Replay ↗︎

@replay-delta
Copy link

replay-delta bot commented Mar 16, 2023

1 of 384 changed

overflowing-array-first-bucket-expanded.png

@jcmorrow jcmorrow merged commit 280aa2f into main Mar 16, 2023
@bvaughn bvaughn deleted the jm-revert-tour branch June 30, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants