Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inventory pages for part numbers with '/' characters will not load #164

Closed
replaysMike opened this issue Apr 20, 2023 · 1 comment · Fixed by #216
Closed

Inventory pages for part numbers with '/' characters will not load #164

replaysMike opened this issue Apr 20, 2023 · 1 comment · Fixed by #216
Assignees
@replaysMike
Labels
binner-cloud Issues that target Binner Cloud (binner.io) bug Something isn't working
Milestone
v2.6.0

Comments

@replaysMike
Copy link
Owner

I just had this issue on binner.io
part: RMC1/10-221JTP, imported from Mouser api
clicking on part redirects to https://binner.io/inventory/RMC1/10-221JTP
https://binner.io/inventory/RMC1%2F10-221JTP loads the correct page

Originally posted by @rebelonion in #14 (comment)
@replaysMike replaysMike self-assigned this Apr 20, 2023
@replaysMike replaysMike added bug Something isn't working binner-cloud Issues that target Binner Cloud (binner.io) labels Apr 20, 2023
@replaysMike replaysMike mentioned this issue Apr 20, 2023
Closed
@replaysMike replaysMike added this to the v2.6.0 milestone Jun 27, 2023
@replaysMike
Copy link
Owner Author

replaysMike commented Jun 27, 2023 •
edited

Fixed in v2.6.0

replaysMike added a commit that referenced this issue Jun 27, 2023
@replaysMike
Fixes #164 - Inventory pages for part numbers with '/' characters wil…
007dc2e 
…l not load

Fixes #214 - Spaces aren't encoded/decoded correctly in part numbers

I couldn't find any other source of this problem, a user reported that the part number appears with %20 in the name of the part. This shouldn't be possible through the UI, unless something was double encoded.
@replaysMike replaysMike mentioned this issue Jun 27, 2023
Merged
replaysMike added a commit that referenced this issue Jun 27, 2023
@replaysMike
Fixes #164 - Inventory pages for part numbers with '/' characters wil…
0a23700 
…l not load

Fixes #214 - Spaces aren't encoded/decoded correctly in part numbers

I couldn't find any other source of this problem, a user reported that the part number appears with %20 in the name of the part. This shouldn't be possible through the UI, unless something was double encoded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@replaysMike replaysMike

Labels
binner-cloud Issues that target Binner Cloud (binner.io) bug Something isn't working
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

Releases/v2.6.0 replaysMike/Binner
1 participant
@replaysMike