Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Spaces aren't encoded/decoded correctly in part numbers #214

Closed
replaysMike opened this issue Jun 24, 2023 · 1 comment · Fixed by #216
Closed

[Bug]: Spaces aren't encoded/decoded correctly in part numbers #214

replaysMike opened this issue Jun 24, 2023 · 1 comment · Fixed by #216
Assignees
@replaysMike
Labels
bug Something isn't working
Milestone
v2.6.0

Comments

@replaysMike
Copy link
Owner

replaysMike commented Jun 24, 2023 •
edited

Binner version

v2.5.9

Operating System

Debian 11

Describe the bug and the steps to reproduce it

Ensure spaces in part numbers aren't stored in the DB as %20, somewhere it's not being encoded correctly and making it to the database.

[via Discord] @xianming

image

image

image

Would you like to attach your appsetings.json configuration?

No response

Screenshots or Videos (Optional, but they help!)

No response

Are you able to contribute a PR? (No is ok!)

Yes, I am also opening a PR that solves the problem along side this issue
@replaysMike replaysMike added the bug Something isn't working label Jun 24, 2023
@replaysMike replaysMike self-assigned this Jun 24, 2023
@replaysMike replaysMike added the in-progress This ticket is currently being worked on label Jun 26, 2023
@replaysMike
Copy link
Owner Author

Fixed in v2.6.0

@replaysMike replaysMike removed the in-progress This ticket is currently being worked on label Jun 27, 2023
@replaysMike replaysMike added this to the v2.6.0 milestone Jun 27, 2023
replaysMike added a commit that referenced this issue Jun 27, 2023
@replaysMike
Fixes #164 - Inventory pages for part numbers with '/' characters wil…
007dc2e 
…l not load

Fixes #214 - Spaces aren't encoded/decoded correctly in part numbers

I couldn't find any other source of this problem, a user reported that the part number appears with %20 in the name of the part. This shouldn't be possible through the UI, unless something was double encoded.
@replaysMike replaysMike mentioned this issue Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@replaysMike replaysMike

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

Releases/v2.6.0 replaysMike/Binner
1 participant
@replaysMike