Make cog local runner match /tmp/shm size on Replicate #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup on replicate#1293 (comment) Signed-off-by: Nelson Chen <crazysim@gmail.com>
|
The limit on replicate should be min(50% system memory, 8GB). Which instance size did you check this with? |
|
Tesla T4 |
|
@yorickvP @technillogue Is 6GB the correct value to use here? Or is 8GB correct? |
mattt
approved these changes
Jun 25, 2024
|
@nelsonjchen Thanks for taking the time to open this PR. Sorry for not acting on it sooner. I'm merging this now and will cut a release with this change later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #1293 (comment)