Switch to keyword arguments for queue worker #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilstreak
force-pushed
the
switch-to-keyword-arguments
branch
from
77f5b2d
to
526376b
Compare
The positional arguments are trouble waiting to happen. Switch over to keyword arguments which are less fragile, and can provide typing automatically. We'll need to do at least one release with this before dropping positional arguments, to give folks a chance to update how they run Cog. We we do drop positional arguments we should make most of the keyword arguments required. I've updated a couple of tests but left the rest, so we can be confident both positional and keyword arguments work. We can swap the rest when we remove positional args. Signed-off-by: Dominic Baggott <dominic.baggott@gmail.com>
evilstreak
force-pushed
the
switch-to-keyword-arguments
branch
from
526376b
to
50d9bf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The positional arguments are trouble waiting to happen. Switch over to keyword arguments which are less fragile, and can provide typing automatically.
We'll need to do at least one release with this before dropping positional arguments, to give folks a chance to update how they run Cog. We we do drop positional arguments we should make most of the keyword arguments required.
I've updated a couple of tests but left the rest, so we can be confident both positional and keyword arguments work. We can swap the rest when we remove positional args.