Reset HTTP request body after reading the stream during webhook validation #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
approved these changes
May 24, 2024
|
Thanks so much for your contribution, @shonun1. I think you're spot on with this change. Once CI passes, I'll merge this in and cut a new release. |
|
Thank you for the quick response and release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I couldn't find any contribution guidelines in the repository, so I've done my best to follow the existing conventions. If there are any issues with this contribution, please let me know.
To give a bit of context on the change: I started using the
ValidateWebhookRequestfunction in the API I was developing. However, I encountered an issue where the HTTP request body was left empty after validation and I needed it for further processing. While I implemented a workaround on my end, I believe the proper solution is to reset the buffer inside the validation function to avoid interfering with any of the input data. More people might encounter this issue when the library is more widely used, so I thought I would attempt to make this change directly in the library. I look forward to your feedback!