bug: added --no-port-forward flag for install command #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![label-checker[bot]](https://avatars.githubusercontent.com/u/8120523?s=60&v=4){kind=small}
sgalsaleh
approved these changes
Feb 25, 2022
cbodonnell
deleted the
craigodonnell/sc-38396/kots-install-port-forward-flag-doesn-t-work
branch
GraysonNull
added a commit
that referenced
this pull request
Mar 2, 2022
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
pavansokkenagaraj
pushed a commit
that referenced
this pull request
Mar 8, 2022
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
pavansokkenagaraj
pushed a commit
that referenced
this pull request
Mar 8, 2022
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
pavansokkenagaraj
pushed a commit
that referenced
this pull request
Mar 10, 2022
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
pavansokkenagaraj
pushed a commit
that referenced
this pull request
Mar 10, 2022
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
pavansokkenagaraj
pushed a commit
that referenced
this pull request
Mar 11, 2022
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
pavansokkenagaraj
pushed a commit
that referenced
this pull request
Mar 11, 2022
* map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * Grayson/preflight UI updates (#2572) * bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com> * clean up * persist rendered preflight spec * update mock funcs * return false, nil when there is no preflight spec * Update AppVersionHistoryRow.jsx * Update pkg/version/version.go Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * Update pkg/store/kotsstore/version_store.go Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * address review comment * refactor to use existing store funcs * remove error logger * feat: remove calling applist from preflight * Update preflight_store.go * add 15 min polling timeout * simplify analyzer loop * rename val * Update kots.go * add strict-preflight-checks testim test * clean up * add validate-strict-preflight-checks * fix validate-strict-preflight-checks test * trigger new github job * test new pr workflow * Update pr-test.yaml * Update pr-test.yaml * Update pr-test.yaml * clean up build-test workflows * remove test-okteto-env * Apply suggestions from code review Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * remove pr-test github job file Co-authored-by: garcialuis <luis@replicated.com> Co-authored-by: GraysonNull <graysonnull@me.com> Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com>
kcboyle
pushed a commit
that referenced
this pull request
Mar 14, 2022
* map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * Grayson/preflight UI updates (#2572) * bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com> * clean up * persist rendered preflight spec * update mock funcs * return false, nil when there is no preflight spec * Update AppVersionHistoryRow.jsx * Update pkg/version/version.go Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * Update pkg/store/kotsstore/version_store.go Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * address review comment * refactor to use existing store funcs * remove error logger * feat: remove calling applist from preflight * Update preflight_store.go * add 15 min polling timeout * simplify analyzer loop * rename val * Update kots.go * add strict-preflight-checks testim test * clean up * add validate-strict-preflight-checks * fix validate-strict-preflight-checks test * trigger new github job * test new pr workflow * Update pr-test.yaml * Update pr-test.yaml * Update pr-test.yaml * clean up build-test workflows * remove test-okteto-env * Apply suggestions from code review Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * remove pr-test github job file Co-authored-by: garcialuis <luis@replicated.com> Co-authored-by: GraysonNull <graysonnull@me.com> Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type::bug
What this PR does / why we need it:
The existing flag --port-forward defaults to true and was inconsistent with the rest of the boolean flags, which default to false. This occasionally led to support requests where
--port-forward falsewas not leading to the expected behavior. This PR introduces a new flag--no-port-forwardthat defaults to false and deprecates the old--port-forwardflag.Which issue(s) this PR fixes:
Fixes SC-38396
Special notes for your reviewer:
Also modified the Github actions to use this new flag in place of
--port-forward=false.Does this PR introduce a user-facing change?
Does this PR require documentation?
Yes: Docs PR