-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update troubleshoot to v0.30.0 to fix viewing pod details #2571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Label type:: is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Label type:: is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Label bug:: required when label type::bug is present.
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
* bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com>
* map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * Grayson/preflight UI updates (#2572) * bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com> * clean up * persist rendered preflight spec * update mock funcs * return false, nil when there is no preflight spec * Update AppVersionHistoryRow.jsx * Update pkg/version/version.go Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * Update pkg/store/kotsstore/version_store.go Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * address review comment * refactor to use existing store funcs * remove error logger * feat: remove calling applist from preflight * Update preflight_store.go * add 15 min polling timeout * simplify analyzer loop * rename val * Update kots.go * add strict-preflight-checks testim test * clean up * add validate-strict-preflight-checks * fix validate-strict-preflight-checks test * trigger new github job * test new pr workflow * Update pr-test.yaml * Update pr-test.yaml * Update pr-test.yaml * clean up build-test workflows * remove test-okteto-env * Apply suggestions from code review Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * remove pr-test github job file Co-authored-by: garcialuis <luis@replicated.com> Co-authored-by: GraysonNull <graysonnull@me.com> Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com>
* map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * Grayson/preflight UI updates (#2572) * bug: added --no-port-forward flag for install command (#2559) * fix the incorrect svc endpoint in the modal (#2564) * bug: suppress warning if API version returned is invalid (#2565) * bug: properly parse cli and api semver * refactored CompareVersions and added test * added second nightly build (#2569) * Update troubleshoot to v0.30.0 to fix viewing pod details (#2571) * map strict flag * add blockDeployment on backend * add deployment block on UI * CLI updates * changed skip-preflight error to warn * override skip-preflights when having strict preflights * bug fix: pass SkipPreflights to persist * fix: add hasStrictPreflights for check * update: add logging * update: add comments * initial ui updates * cleanup the new preflight UI * update text for if a required text fails Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> Co-authored-by: Pavan Sokke Nagaraj <pavan@replicated.com> Co-authored-by: garcialuis <luis@replicated.com> * clean up * persist rendered preflight spec * update mock funcs * return false, nil when there is no preflight spec * Update AppVersionHistoryRow.jsx * Update pkg/version/version.go Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * Update pkg/store/kotsstore/version_store.go Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * address review comment * refactor to use existing store funcs * remove error logger * feat: remove calling applist from preflight * Update preflight_store.go * add 15 min polling timeout * simplify analyzer loop * rename val * Update kots.go * add strict-preflight-checks testim test * clean up * add validate-strict-preflight-checks * fix validate-strict-preflight-checks test * trigger new github job * test new pr workflow * Update pr-test.yaml * Update pr-test.yaml * Update pr-test.yaml * clean up build-test workflows * remove test-okteto-env * Apply suggestions from code review Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com> * remove pr-test github job file Co-authored-by: garcialuis <luis@replicated.com> Co-authored-by: GraysonNull <graysonnull@me.com> Co-authored-by: Craig O'Donnell <craig@replicated.com> Co-authored-by: Jalaja Ganapathy <jalaja@replicated.com> Co-authored-by: Salah Al Saleh <sg.alsaleh@gmail.com>
What type of PR is this?
type::bug
What this PR does / why we need it:
Updates troubleshoot to v0.30.0 to fix viewing pod details in the troubleshoot analysis page.
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE