Additional namespaces flag #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marccampbell
force-pushed
the
additional-rbac
branch
from
57836a7
to
1009c9e
Compare
divolgin
reviewed
Mar 3, 2020
pkg/kotsadm/namespaces.go
Outdated
|
|
||
| application := obj.(*kotsv1beta1.Application) | ||
|
|
||
| if application.Spec.AdditionalNamespaces == nil { |
There was a problem hiding this comment.
don't need this. loop works with nil arrays
divolgin
reviewed
Mar 3, 2020
| } | ||
|
|
||
| for _, additionalNamespace := range application.Spec.AdditionalNamespaces { | ||
| // We support "*" for additional namespaces to handle pullsecret propagation |
There was a problem hiding this comment.
We do, but we don't create that. It (will be) handled in the kotsadm code to handle imagePulLSecret propagation
There was a problem hiding this comment.
Does this then break on something like this:
- custom_ns
- worker*
There was a problem hiding this comment.
unsupported. only "*" and/or specific (exact) namespaces
divolgin
approved these changes
Mar 3, 2020
divolgin
approved these changes
Mar 4, 2020
divolgin
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.