feat: add test for HostPreflight spec read (#1227)

replicatedhq · Jun 22, 2023 · 2c6b186 · 2c6b186
1 parent 944da45
commit 2c6b186
Showing 1 changed file with 52 additions and 11 deletions.
diff --git a/pkg/preflight/read_specs_test.go b/pkg/preflight/read_specs_test.go
@@ -103,19 +103,51 @@ func TestPreflightSpecsRead(t *testing.T) {
 		},
 	}
 
-	/*
-		expectHostPreflightSpec := troubleshootv1beta2.HostPreflight{
-				TypeMeta: metav1.TypeMeta{
-					Kind:       "HostPreflight",
-					APIVersion: "troubleshoot.sh/troubleshootv1beta2",
+	// A HostPreflight spec
+	hostpreflightFile := filepath.Join(testutils.FileDir(), "../../examples/preflight/host/block-devices.yaml")
+	//
+	expectHostPreflightSpec := troubleshootv1beta2.HostPreflight{
+		TypeMeta: metav1.TypeMeta{
+			Kind:       "HostPreflight",
+			APIVersion: "troubleshoot.sh/v1beta2",
+		},
+		ObjectMeta: metav1.ObjectMeta{
+			Name: "block",
+		},
+		Spec: troubleshootv1beta2.HostPreflightSpec{
+			Collectors: []*troubleshootv1beta2.HostCollect{
+				{
+					BlockDevices: &troubleshootv1beta2.HostBlockDevices{},
 				},
-				Spec: troubleshootv1beta2.HostPreflightSpec{
-					Collectors:       []*troubleshootv1beta2.HostCollect(nil),
-					RemoteCollectors: []*troubleshootv1beta2.RemoteCollect(nil),
-					Analyzers:        []*troubleshootv1beta2.HostAnalyze(nil),
+			},
+			RemoteCollectors: []*troubleshootv1beta2.RemoteCollect(nil),
+			Analyzers: []*troubleshootv1beta2.HostAnalyze{
+				{
+					BlockDevices: &troubleshootv1beta2.BlockDevicesAnalyze{
+						Outcomes: []*troubleshootv1beta2.Outcome{
+							{
+								Pass: &troubleshootv1beta2.SingleOutcome{
+									When:    ".* == 1",
+									Message: "One available block device",
+								},
+							},
+							{
+								Pass: &troubleshootv1beta2.SingleOutcome{
+									When:    ".* > 1",
+									Message: "Multiple available block devices",
+								},
+							},
+							{
+								Fail: &troubleshootv1beta2.SingleOutcome{
+									Message: "No available block devices",
+								},
+							},
+						},
+					},
 				},
-			}
-	*/
+			},
+		},
+	}
 
 	// A more complexed preflight spec, which resides in a secret
 	preflightSecretFile := filepath.Join(testutils.FileDir(), "../../testdata/preflightspec/troubleshoot_v1beta2_preflight_secret_gotest.yaml")
@@ -193,6 +225,15 @@ func TestPreflightSpecsRead(t *testing.T) {
 			wantHostPreflightSpec: nil,
 			wantUploadResultSpecs: nil,
 		},
+		PreflightSpecsReadTest{
+			name:                  "file-hostpreflight",
+			args:                  []string{hostpreflightFile},
+			customStdin:           false,
+			wantErr:               false,
+			wantPreflightSpec:     nil,
+			wantHostPreflightSpec: &expectHostPreflightSpec,
+			wantUploadResultSpecs: nil,
+		},
 		PreflightSpecsReadTest{
 			name:                  "file-secret",
 			args:                  []string{preflightSecretFile},