Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test for HostPreflight spec read #1227

Merged
merged 1 commit into from
Jun 22, 2023
Merged

feat: add test for HostPreflight spec read #1227

merged 1 commit into from
Jun 22, 2023

Conversation

xavpaice
Copy link
Member

@xavpaice xavpaice commented Jun 16, 2023 •
edited

Description, Motivation and Context

Adds an extra test for reading HostPreflight specs.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@xavpaice xavpaice requested a review from a team as a code owner June 16, 2023 03:00
CpuID
CpuID approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@CpuID CpuID left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@banjoh banjoh merged commit 2c6b186 into main Jun 22, 2023
21 of 22 checks passed
@banjoh banjoh deleted the add-tests branch June 22, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banjoh banjoh banjoh approved these changes

@CpuID CpuID CpuID approved these changes

Assignees
No one assigned
Labels
type::chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xavpaice @banjoh @CpuID